[epiphany] ephy-bookmark-properties: close is not an action
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] ephy-bookmark-properties: close is not an action
- Date: Mon, 25 Aug 2014 14:17:53 +0000 (UTC)
commit 1a0ad7b10d443c26a1b9b23526e8699ab649f078
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Wed Aug 20 13:34:04 2014 -0500
ephy-bookmark-properties: close is not an action
We use a traditional X button for close, we don't spell it out as a
suggested-action.
This dialog is a bit confusing because it is used for both creating and
viewing bookmarks. When creating bookmarks, it's an action dialog and we
need to use gtk_dialog_add_button() to create our choices (cancel at the
start of the header bar, and suggested Add at the end). But when not
creating a bookmark, it's a presentation dialog and so calling
gtk_dialog_add_button() is wrong.
https://bugzilla.gnome.org/show_bug.cgi?id=735115
src/bookmarks/ephy-bookmark-properties.c | 7 -------
1 files changed, 0 insertions(+), 7 deletions(-)
---
diff --git a/src/bookmarks/ephy-bookmark-properties.c b/src/bookmarks/ephy-bookmark-properties.c
index 2576b93..5f20f2d 100644
--- a/src/bookmarks/ephy-bookmark-properties.c
+++ b/src/bookmarks/ephy-bookmark-properties.c
@@ -432,13 +432,6 @@ ephy_bookmark_properties_constructor (GType type,
GTK_RESPONSE_ACCEPT);
gtk_dialog_set_default_response (dialog, GTK_RESPONSE_ACCEPT);
}
- else
- {
- gtk_dialog_add_button (dialog,
- _("_Close"),
- GTK_RESPONSE_CLOSE);
- gtk_dialog_set_default_response (dialog, GTK_RESPONSE_CLOSE);
- }
update_warning (properties);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]