[gtk+] GtkAboutDialog: Drop visibility-notify-event handler
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] GtkAboutDialog: Drop visibility-notify-event handler
- Date: Sat, 23 Aug 2014 05:28:36 +0000 (UTC)
commit 08066b100957ff6ce9beaf5c6f5bfcad59928d7f
Author: Matthias Clasen <mclasen redhat com>
Date: Sat Aug 23 01:25:35 2014 -0400
GtkAboutDialog: Drop visibility-notify-event handler
The signal is deprecated, and the handler is only helping
for a really tiny corner case anyway.
https://bugzilla.gnome.org/show_bug.cgi?id=734961
gtk/gtkaboutdialog.c | 41 ------------------------------------
gtk/resources/ui/gtkaboutdialog.ui | 1 -
2 files changed, 0 insertions(+), 42 deletions(-)
---
diff --git a/gtk/gtkaboutdialog.c b/gtk/gtkaboutdialog.c
index 85daec4..b76742e 100644
--- a/gtk/gtkaboutdialog.c
+++ b/gtk/gtkaboutdialog.c
@@ -241,9 +241,6 @@ static gboolean text_view_event_after (GtkWidget
static gboolean text_view_motion_notify_event (GtkWidget *text_view,
GdkEventMotion *event,
GtkAboutDialog *about);
-static gboolean text_view_visibility_notify_event(GtkWidget *text_view,
- GdkEventVisibility *event,
- GtkAboutDialog *about);
static void toggle_credits (GtkToggleButton *button,
gpointer user_data);
static void toggle_license (GtkToggleButton *button,
@@ -599,7 +596,6 @@ gtk_about_dialog_class_init (GtkAboutDialogClass *klass)
gtk_widget_class_bind_template_callback (widget_class, emit_activate_link);
gtk_widget_class_bind_template_callback (widget_class, text_view_event_after);
gtk_widget_class_bind_template_callback (widget_class, text_view_key_press_event);
- gtk_widget_class_bind_template_callback (widget_class, text_view_visibility_notify_event);
gtk_widget_class_bind_template_callback (widget_class, text_view_motion_notify_event);
gtk_widget_class_bind_template_callback (widget_class, stack_visible_child_notify);
}
@@ -2057,43 +2053,6 @@ text_view_motion_notify_event (GtkWidget *text_view,
return FALSE;
}
-
-static gboolean
-text_view_visibility_notify_event (GtkWidget *text_view,
- GdkEventVisibility *event,
- GtkAboutDialog *about)
-{
- GdkDeviceManager *device_manager;
- GdkDisplay *display;
- GList *devices, *d;
- gint wx, wy, bx, by;
-
- display = gdk_window_get_display (event->window);
- device_manager = gdk_display_get_device_manager (display);
- devices = gdk_device_manager_list_devices (device_manager, GDK_DEVICE_TYPE_MASTER);
-
- for (d = devices; d; d = d->next)
- {
- GdkDevice *dev = d->data;
-
- if (gdk_device_get_source (dev) == GDK_SOURCE_KEYBOARD)
- continue;
-
- gdk_window_get_device_position (gtk_widget_get_window (text_view), dev,
- &wx, &wy, NULL);
-
- gtk_text_view_window_to_buffer_coords (GTK_TEXT_VIEW (text_view),
- GTK_TEXT_WINDOW_WIDGET,
- wx, wy, &bx, &by);
-
- set_cursor_if_appropriate (about, GTK_TEXT_VIEW (text_view), dev, bx, by);
- }
-
- g_list_free (devices);
-
- return FALSE;
-}
-
static GtkTextBuffer *
text_buffer_new (GtkAboutDialog *about,
gchar **strings)
diff --git a/gtk/resources/ui/gtkaboutdialog.ui b/gtk/resources/ui/gtkaboutdialog.ui
index 30050de..cc75d77 100644
--- a/gtk/resources/ui/gtkaboutdialog.ui
+++ b/gtk/resources/ui/gtkaboutdialog.ui
@@ -274,7 +274,6 @@
<signal name="event-after" handler="text_view_event_after" swapped="no"/>
<signal name="key-press-event" handler="text_view_key_press_event" swapped="no"/>
<signal name="motion-notify-event" handler="text_view_motion_notify_event"
swapped="no"/>
- <signal name="visibility-notify-event"
handler="text_view_visibility_notify_event" swapped="no"/>
</object>
</child>
</object>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]