[gnome-desktop] gnome-rr: Initialize GnomeRROutputInfo:rotation to GNOME_RR_ROTATION_0



commit 07480cb20cf4155a6e975a011211ea98d57037fa
Author: Debarshi Ray <debarshir gnome org>
Date:   Wed Mar 26 15:35:09 2014 +0100

    gnome-rr: Initialize GnomeRROutputInfo:rotation to GNOME_RR_ROTATION_0
    
    Otherwise, the GnomeRROutputInfos representing connected but inactive
    outputs (ie. without an assigned CRTC) had their rotations set to
    GNOME_RR_ROTATION_NEXT, which is not a valid value. This leads to
    gnome_rr_config_applicable returning FALSE, because it thinks that one
    of the outputs require a rotation that is not supported by any of the
    available CRTCs.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=727023

 libgnome-desktop/gnome-rr-config.c      |    1 -
 libgnome-desktop/gnome-rr-output-info.c |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libgnome-desktop/gnome-rr-config.c b/libgnome-desktop/gnome-rr-config.c
index 976fb92..616c45e 100644
--- a/libgnome-desktop/gnome-rr-config.c
+++ b/libgnome-desktop/gnome-rr-config.c
@@ -172,7 +172,6 @@ gnome_rr_config_load_current (GnomeRRConfig *config, GError **error)
            output->priv->width = -1;
            output->priv->height = -1;
            output->priv->rate = -1;
-           output->priv->rotation = GNOME_RR_ROTATION_0;
        }
        else
        {
diff --git a/libgnome-desktop/gnome-rr-output-info.c b/libgnome-desktop/gnome-rr-output-info.c
index 5422db3..33fdb14 100644
--- a/libgnome-desktop/gnome-rr-output-info.c
+++ b/libgnome-desktop/gnome-rr-output-info.c
@@ -39,6 +39,7 @@ gnome_rr_output_info_init (GnomeRROutputInfo *self)
 
     self->priv->name = NULL;
     self->priv->on = FALSE;
+    self->priv->rotation = GNOME_RR_ROTATION_0;
     self->priv->display_name = NULL;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]