[perl-GStreamer] Avoid misusing PL_na
- From: Torsten Schönfeld <tsch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [perl-GStreamer] Avoid misusing PL_na
- Date: Wed, 25 Sep 2013 18:41:18 +0000 (UTC)
commit f9277a12417ff76e6bbd0dc885e3a479158dc015
Author: Torsten Schönfeld <kaffeetisch gmx de>
Date: Wed Sep 25 20:40:58 2013 +0200
Avoid misusing PL_na
NEWS | 7 +++++++
xs/GstStructure.xs | 2 +-
xs/GstValue.xs | 4 ++--
3 files changed, 10 insertions(+), 3 deletions(-)
---
diff --git a/NEWS b/NEWS
index 3e89250..bc0e45f 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,10 @@
+Overview of changes in GStreamer <next>
+=====================================
+
+* Avoid misusing the macro PL_na, thus preventing potential issues when
+ GStreamer is used in conjunction with certain XS modules, among them
+ XML::Parser and String::Approx.
+
Overview of changes in GStreamer 0.18
=====================================
diff --git a/xs/GstStructure.xs b/xs/GstStructure.xs
index 93593b8..b2c17df 100644
--- a/xs/GstStructure.xs
+++ b/xs/GstStructure.xs
@@ -112,7 +112,7 @@ fill_av (GQuark field_id,
field = newAV ();
av_push (field, newSVGChar (id));
- av_push (field, newSVpv (type, PL_na));
+ av_push (field, newSVpv (type, 0));
av_push (field, gperl_sv_from_value (value));
av_push (fields, newRV_noinc ((SV *) field));
diff --git a/xs/GstValue.xs b/xs/GstValue.xs
index 2344f32..a7037ed 100644
--- a/xs/GstValue.xs
+++ b/xs/GstValue.xs
@@ -165,7 +165,7 @@ gst2perl_value_list_wrap (const GValue *value)
/* FIXME: Can this cause deadlocks? */
av_push (list_av, gperl_sv_from_value (list_value));
- av_push (list_av, newSVpv (gperl_package_from_type (G_VALUE_TYPE (list_value)), PL_na));
+ av_push (list_av, newSVpv (gperl_package_from_type (G_VALUE_TYPE (list_value)), 0));
av_push (av, newRV_noinc ((SV *) list_av));
}
@@ -249,7 +249,7 @@ gst2perl_value_array_wrap (const GValue *value)
/* FIXME: Can this cause deadlocks? */
av_push (list_av, gperl_sv_from_value (list_value));
- av_push (list_av, newSVpv (gperl_package_from_type (G_VALUE_TYPE (list_value)), PL_na));
+ av_push (list_av, newSVpv (gperl_package_from_type (G_VALUE_TYPE (list_value)), 0));
av_push (av, newRV_noinc ((SV *) list_av));
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]