[banshee] build: make the 'test' target depend on the 'all' target



commit 2f088f3ca6aebae1a5915170a9491aead44dc73f
Author: Andrés G. Aragoneses <knocte gmail com>
Date:   Sun Sep 8 16:06:02 2013 +0200

    build: make the 'test' target depend on the 'all' target
    
    This would fix some scenarios that some developers could run into:
    
    a) Run `./autogen.sh --enable-tests`, and after that `make test`
    without running `make` before (which would yield many "Could not
    find file foo.dll" errors).
    
    b) Run `./autogen.sh`, then `make`, then `make test` which would
    yield "make[1]: *** No rule to make target `test'.  Stop.", and
    (hopefully) make the developer realise that she was lacking the
    --enable-tests flag for the configuration phase, so then she'd
    then run `./autogen.sh --enable-tests && make test`, which would
    cause nunit-console to be run in assemblies which didn't contain
    tests.
    
    The (b) case is more severe because it could be very misleading,
    making the developer think that tests passed (as the execution of
    NUnit runner wouldn't yield any test error), when they may have
    not.

 Makefile.am |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/Makefile.am b/Makefile.am
index d48e450..7fc9ba1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -112,7 +112,7 @@ csharp:
     csharp -lib:bin/ -pkg:glib-sharp-2.0 -pkg:gtk-sharp-2.0 -pkg:gconf-sharp-2.0 -pkg:dbus-sharp 
-pkg:taglib-sharp -pkg:ipod-sharp -pkg:mono-addins $(addprefix "-reference:", $(wildcard bin/*.dll)); \
        popd;
 
-test:
+test: all
        @pushd tests; \
        make test \
        popd;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]