[gnome-shell] Suppress animation for titles in overview
- From: Adel Gadllah <agadllah src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] Suppress animation for titles in overview
- Date: Thu, 10 Oct 2013 06:51:28 +0000 (UTC)
commit 20c18c1fc0fcad58bdf11309e245117ad147d219
Author: Sebastien Lafargue <slaf66 gmail com>
Date: Thu Oct 3 23:08:59 2013 +0200
Suppress animation for titles in overview
Because of the animation and collision with relayout, the title of windows in overview may not appear,
mainly
the first time we enter in overview
With an animation delay of 0.1s, you'll not see the difference
https://bugzilla.gnome.org/show_bug.cgi?id=709392
js/ui/workspace.js | 26 ++++----------------------
1 files changed, 4 insertions(+), 22 deletions(-)
---
diff --git a/js/ui/workspace.js b/js/ui/workspace.js
index 52a737c..75683ba 100644
--- a/js/ui/workspace.js
+++ b/js/ui/workspace.js
@@ -343,19 +343,6 @@ const WindowOverlay = new Lang.Class({
this._animateVisible();
},
- fadeIn: function() {
- if (!this._hidden)
- return;
-
- this.show();
- this.title.opacity = 0;
- this._parentActor.raise_top();
- Tweener.addTween(this.title,
- { opacity: 255,
- time: CLOSE_BUTTON_FADE_TIME,
- transition: 'easeOutQuad' });
- },
-
chromeHeights: function () {
return [Math.max(this.borderSize, this.closeButton.height - this.closeButton._overlap),
this.title.height + this.title._spacing];
@@ -372,7 +359,6 @@ const WindowOverlay = new Lang.Class({
let border = this.border;
Tweener.removeTweens(button);
- Tweener.removeTweens(title);
Tweener.removeTweens(border);
let [cloneX, cloneY, cloneWidth, cloneHeight] = this._windowClone.slot;
@@ -1142,7 +1128,7 @@ const Workspace = new Lang.Class({
clone.actor.set_scale(scale, scale);
clone.actor.set_opacity(255);
clone.overlay.relayout(false);
- this._showWindowOverlay(clone, overlay, isOnCurrentWorkspace);
+ this._showWindowOverlay(clone, overlay);
}
}
},
@@ -1172,23 +1158,19 @@ const Workspace = new Lang.Class({
time: Overview.ANIMATION_TIME,
transition: 'easeOutQuad',
onComplete: Lang.bind(this, function() {
- this._showWindowOverlay(clone, overlay, true);
+ this._showWindowOverlay(clone, overlay);
})
});
clone.overlay.relayout(true);
},
- _showWindowOverlay: function(clone, overlay, fade) {
+ _showWindowOverlay: function(clone, overlay) {
if (clone.inDrag)
return;
- if (overlay) {
- if (fade)
- overlay.fadeIn();
- else
+ if (overlay && overlay._hidden)
overlay.show();
- }
},
_delayedWindowRepositioning: function() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]