[at-spi2-atk/gnome-3-8] Add a NULL check into register_reply



commit 67c512ccdd517dab81821cecfb396a04dd2714ea
Author: Mike Gorse <mgorse suse com>
Date:   Fri May 3 09:48:50 2013 -0500

    Add a NULL check into register_reply
    
    Register_reply could access invalid memory if it is called after
    atk_bridge_adaptor_cleanup() has been called.
    
    This code should probably be refactored to make the instance act as a
    GObject, but committing this for now to fix the crash.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=699554

 atk-adaptor/bridge.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/atk-adaptor/bridge.c b/atk-adaptor/bridge.c
index 1a36f14..e59c834 100644
--- a/atk-adaptor/bridge.c
+++ b/atk-adaptor/bridge.c
@@ -235,6 +235,14 @@ register_reply (DBusPendingCall *pending, void *user_data)
 
   reply = dbus_pending_call_steal_reply (pending);
   dbus_pending_call_unref (pending);
+
+  if (!spi_global_app_data)
+    {
+      if (reply)
+         dbus_message_unref (reply);
+      return;
+    }
+
   if (reply)
     {
       gchar *app_name, *obj_path;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]