[at-spi2-atk] Add a NULL check into register_reply
- From: Mike Gorse <mgorse src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [at-spi2-atk] Add a NULL check into register_reply
- Date: Fri, 3 May 2013 14:51:36 +0000 (UTC)
commit 031946b5b7ec90279ae60bbf974f23979979ea78
Author: Mike Gorse <mgorse suse com>
Date: Fri May 3 09:48:50 2013 -0500
Add a NULL check into register_reply
Register_reply could access invalid memory if it is called after
atk_bridge_adaptor_cleanup() has been called.
This code should probably be refactored to make the instance act as a
GObject, but committing this for now to fix the crash.
https://bugzilla.gnome.org/show_bug.cgi?id=699554
atk-adaptor/bridge.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
---
diff --git a/atk-adaptor/bridge.c b/atk-adaptor/bridge.c
index 1a36f14..e59c834 100644
--- a/atk-adaptor/bridge.c
+++ b/atk-adaptor/bridge.c
@@ -235,6 +235,14 @@ register_reply (DBusPendingCall *pending, void *user_data)
reply = dbus_pending_call_steal_reply (pending);
dbus_pending_call_unref (pending);
+
+ if (!spi_global_app_data)
+ {
+ if (reply)
+ dbus_message_unref (reply);
+ return;
+ }
+
if (reply)
{
gchar *app_name, *obj_path;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]