[glibmm] Gio: Add some TODOs about changing the base classes.



commit c43ced750b04b8ae0556e8dfe317a4dbb6da327f
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Mar 26 10:45:38 2013 +0100

    Gio: Add some TODOs about changing the base classes.
    
        * gio/src/actionmap.hg
        * gio/src/pollableinputstream.hg
        * gio/src/pollableoutputstream.hg
        * gio/src/remoteactiongroup.hg:
        We should probably derive from their prerequisite
        (required) classes instead. These were added in
        glibmm 2.34.

 ChangeLog                       |   12 ++++++++++++
 gio/src/actionmap.hg            |    4 ++++
 gio/src/pollableinputstream.hg  |    4 ++++
 gio/src/pollableoutputstream.hg |    4 ++++
 gio/src/remoteactiongroup.hg    |    6 ++++++
 5 files changed, 30 insertions(+), 0 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index c069070..30be934 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2013-03-25  Murray Cumming  <murrayc murrayc com>
+
+       Gio: Add some TODOs about changing the base classes.
+
+       * gio/src/actionmap.hg
+       * gio/src/pollableinputstream.hg
+       * gio/src/pollableoutputstream.hg
+       * gio/src/remoteactiongroup.hg:
+       We should probably derive from their prerequisite
+       (required) classes instead. These were added in
+       glibmm 2.34.
+
 2013-03-25  José Alburquerque  <jaalburquerque gmail com>
 
        giomm: Wrap the GTlsError GError.
diff --git a/gio/src/actionmap.hg b/gio/src/actionmap.hg
index 97c96f1..3a51893 100644
--- a/gio/src/actionmap.hg
+++ b/gio/src/actionmap.hg
@@ -32,6 +32,10 @@ namespace Gio
 
 class Action;
 
+//TODO: Instead derive from ActionGroup, when we can break ABI,
+//because the GActionMap interface requires the GActionGroup interface.
+//LoadableIcon does a similar thing correctly, for instance.
+
 /** ActionMap - Interface for action containers.
  * The ActionMap interface is implemented by ActionGroup implementations that
  * operate by containing a number of named Action instances, such as
diff --git a/gio/src/pollableinputstream.hg b/gio/src/pollableinputstream.hg
index cda87bd..ce4af17 100644
--- a/gio/src/pollableinputstream.hg
+++ b/gio/src/pollableinputstream.hg
@@ -32,6 +32,10 @@ namespace Gio
 
 class Cancellable;
 
+//TODO: Instead derive from InputStream, when we can break ABI,
+//because the GPollableInputStream interface requires the GInputStream interface.
+//LoadableIcon does a similar thing correctly, for instance.
+
 /** PollableInputStream - Interface for pollable input streams.
  * PollableInputStream is implemented by InputStreams that can be polled for
  * readiness to read. This can be used when interfacing with a non-GIO API that
diff --git a/gio/src/pollableoutputstream.hg b/gio/src/pollableoutputstream.hg
index 79c5cfe..c6807c5 100644
--- a/gio/src/pollableoutputstream.hg
+++ b/gio/src/pollableoutputstream.hg
@@ -32,6 +32,10 @@ namespace Gio
 
 class Cancellable;
 
+//TODO: Instead derive from OutputStream, when we can break ABI,
+//because the GPollableOutputStream interface requires the GOutputStream interface.
+//LoadableIcon does a similar thing correctly, for instance.
+
 /** PollableOutputStream - Interface for pollable output streams.
  * PollableOutputStream is implemented by OutputStreams that can be polled for
  * readiness to write. This can be used when interfacing with a non-GIO API
diff --git a/gio/src/remoteactiongroup.hg b/gio/src/remoteactiongroup.hg
index 4dda8af..0ce7159 100644
--- a/gio/src/remoteactiongroup.hg
+++ b/gio/src/remoteactiongroup.hg
@@ -30,6 +30,12 @@ typedef struct _GRemoteActionGroupInterface GRemoteActionGroupInterface;
 namespace Gio
 {
 
+
+//TODO: Instead derive from ActionGroup, when we can break ABI,
+//because the GRemoteActionGroup interface requires the GActionGroup interface.
+//LoadableIcon does a similar thing correctly, for instance.
+
+
 /** RemoteActionGroup - a ActionGroup that interacts with other processes.
  * The RemoteActionGroup interface is implemented by ActionGroup instances that
  * either transmit action invocations to other processes or receive action


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]