[easytag] Do not write COMMENT field for Vorbis and FLAC



commit d5c6e5acda0c47671065b4d0bf436f0fb7c6a634
Author: David King <amigadave amigadave com>
Date:   Sun Mar 24 22:46:59 2013 +0000

    Do not write COMMENT field for Vorbis and FLAC
    
    DESCRIPTION is the field in the Vorbis comment specification for "a
    short text description of the contents" and so it should be used in
    preference to the COMMENT field which is not present in the
    specification. Fixes bug 690297.

 src/flac_tag.c |    4 +---
 src/ogg_tag.c  |    8 ++------
 2 files changed, 3 insertions(+), 9 deletions(-)
---
diff --git a/src/flac_tag.c b/src/flac_tag.c
index e4ca087..091f20b 100644
--- a/src/flac_tag.c
+++ b/src/flac_tag.c
@@ -62,7 +62,7 @@
  *  - ARTIST       : Track performer
  *  - ORGANIZATION : Name of the organization producing the track (i.e. the 'record label')
  *  - DESCRIPTION  : A short text description of the contents
- *  - COMMENT      : same than DESCRIPTION
+ *  - COMMENT      : same as DESCRIPTION
  *  - GENRE        : A short text indication of music genre
  *  - DATE         : Date the track was recorded
  *  - LOCATION     : Location where track was recorded
@@ -971,9 +971,7 @@ gboolean Flac_Tag_Write_File_Tag (ET_File *ETFile)
         /***********
          * Comment *
          ***********/
-        // We write the comment using the "both" format
         Flac_Set_Tag(vc_block,"DESCRIPTION=",FileTag->comment,VORBIS_SPLIT_FIELD_COMMENT);
-        Flac_Set_Tag(vc_block,"COMMENT=",FileTag->comment,VORBIS_SPLIT_FIELD_COMMENT);
 
         /************
          * Composer *
diff --git a/src/ogg_tag.c b/src/ogg_tag.c
index 6152411..0a47529 100644
--- a/src/ogg_tag.c
+++ b/src/ogg_tag.c
@@ -744,16 +744,12 @@ gboolean Ogg_Tag_Write_File_Tag (ET_File *ETFile)
     /***********
      * Comment *
      ***********/
-    // We write the comment using the two formats "DESCRIPTION" and "COMMENT" to be compatible with old 
versions
-    // Format of new specification
+    /* Format of new specification. */
     Ogg_Set_Tag(vc,"DESCRIPTION=",FileTag->comment,VORBIS_SPLIT_FIELD_COMMENT);
 
-    // Format used in winamp plugin
-    Ogg_Set_Tag(vc,"COMMENT=",FileTag->comment,VORBIS_SPLIT_FIELD_COMMENT);
-
     if (OGG_TAG_WRITE_XMMS_COMMENT)
     {
-        // Format used into xmms-1.2.5
+        /* Format used with xmms-1.2.5. */
         Ogg_Set_Tag(vc,"=",FileTag->comment,VORBIS_SPLIT_FIELD_COMMENT);
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]