[gtkhtml] Bug #691362 – gtkhtml/htmltext.c: R eturn correct enum type `PangoDirection` in `get_pango _base_dir
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtkhtml] Bug #691362 – gtkhtml/htmltext.c: R eturn correct enum type `PangoDirection` in `get_pango _base_dir
- Date: Tue, 12 Mar 2013 10:32:25 +0000 (UTC)
commit 8f3dfc0af8c1330dd2df09c763f9295eb09ff869
Author: Paul Menzel <paulepanter users sourceforge net>
Date: Tue Mar 12 11:31:35 2013 +0100
Bug #691362 – gtkhtml/htmltext.c: Return correct enum type `PangoDirection` in `get_pango_base_direction`
$ apt-get source libgtkhtml-4.0-0 # with experimental sources
$ cd gtkhtml4.0-4.6.0
$ clang --version
Debian clang version 3.2-9 (tags/RELEASE_32/final) (based on LLVM 3.2)
Target: i386-pc-linux-gnu
Thread model: posix
$ CC=clang ./configure
[…]
CC htmltext.lo
htmltext.c:1396:11: warning: implicit conversion from enumeration type 'HTMLDirection' to
different enumeration type 'PangoDirection'
[-Wenum-conversion]
return HTML_DIRECTION_LTR;
~~~~~~ ^~~~~~~~~~~~~~~~~~
1 warning generated.
This error is present since the original commit/merge.
commit 3f320b90e0e2bf6b688072d8a8baacdd22ca4691
Author: Radek Doulik <rodo ximian com>
Date: Tue Jan 4 12:47:33 2005 +0000
merge from RTL branch
$ git tag --contains 3f320b90
GNOME_2_16_BRANCHPOINT
GTKHTML3_27_3
GTKHTML3_31_5
GTKHTML_2_23_4
GTKHTML_2_29_91
GTKHTML_3_10_0
Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=691362
gtkhtml/htmltext.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/gtkhtml/htmltext.c b/gtkhtml/htmltext.c
index 35cf56d..babb4e6 100644
--- a/gtkhtml/htmltext.c
+++ b/gtkhtml/htmltext.c
@@ -1393,7 +1393,7 @@ get_pango_base_direction (HTMLText *text)
if (text->text)
return html_text_get_pango_direction (text);
else
- return HTML_DIRECTION_LTR;
+ return PANGO_DIRECTION_LTR;
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]