[gnome-music] Do not create unnecessary window in view.js



commit c9097cfb0122be91c2629765fcf3314646765cb8
Author: Guillaume Quintard <guillaume quintard gmail com>
Date:   Sat Jun 8 21:27:42 2013 +0200

    Do not create unnecessary window in view.js
    
    Albums._onItemActivated creates a unused Gtk.window for nothing, this
    patch corrects it.
    And convert some var in let.
    
    Signed-off-by: Seif Lotfy <seif lotfy com>

 src/view.js |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)
---
diff --git a/src/view.js b/src/view.js
index 7a69ae0..ee4e715 100644
--- a/src/view.js
+++ b/src/view.js
@@ -309,11 +309,10 @@ const Albums = new Lang.Class({
     },
 
     _onItemActivated: function (widget, id, path) {
-        var iter = this._model.get_iter (path)[1];
-        var title = this._model.get_value (iter, 2);
-        var artist = this._model.get_value (iter, 3);
-        var item = this._model.get_value (iter, 5);
-        var window = new Gtk.Window ();
+        let iter = this._model.get_iter (path)[1];
+        let title = this._model.get_value (iter, 2);
+        let artist = this._model.get_value (iter, 3);
+        let item = this._model.get_value (iter, 5);
         this._albumWidget.update (artist, title, item);
         this.header_bar.setState (0);
         this.header_bar.title = title;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]