[evolution/gnome-3-8] Bug 703991: Crash when using -fstack-protector-strong.



commit 29986df668e62063ab4f33cb71edd6f6811ce95f
Author: Matthew Barnes <mbarnes redhat com>
Date:   Fri Jul 12 14:33:49 2013 -0400

    Bug 703991: Crash when using -fstack-protector-strong.
    
    We were using g_object_get() to write an "unsigned int" value (at least
    32 bits) into a 16-bit integer address.
    
    Don't know why we were bothering with g_object_get() in the first place,
    just call camel_network_settings_get_port() instead.
    
    (cherry picked from commit edf24cc3dae97d27aea997d71d8263bdb6f135ef)

 modules/mail-config/e-mail-config-smtp-backend.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/modules/mail-config/e-mail-config-smtp-backend.c 
b/modules/mail-config/e-mail-config-smtp-backend.c
index 0b823f9..0c3d56b 100644
--- a/modules/mail-config/e-mail-config-smtp-backend.c
+++ b/modules/mail-config/e-mail-config-smtp-backend.c
@@ -238,8 +238,8 @@ mail_config_smtp_backend_insert_widgets (EMailConfigServiceBackend *backend,
        priv->user_entry = widget;  /* do not reference */
        gtk_widget_show (widget);
 
-       port = 0;
-       g_object_get (G_OBJECT (settings), "port", &port, NULL);
+       port = camel_network_settings_get_port (
+               CAMEL_NETWORK_SETTINGS (settings));
 
        g_object_bind_property (
                settings, "host",


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]