[gnome-shell] loginDialog: pre-allocate prompt message height
- From: Ray Strode <halfline src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] loginDialog: pre-allocate prompt message height
- Date: Fri, 12 Jul 2013 15:53:58 +0000 (UTC)
commit 6e00b6e2149c716d9b9f899cd57683df96677a31
Author: Ray Strode <rstrode redhat com>
Date: Wed Jun 19 12:56:23 2013 -0400
loginDialog: pre-allocate prompt message height
Right now things jump around if a message comes in.
This commit makes sure there's room for a message to start.
https://bugzilla.gnome.org/show_bug.cgi?id=702308
js/gdm/loginDialog.js | 16 +++++++---------
1 files changed, 7 insertions(+), 9 deletions(-)
---
diff --git a/js/gdm/loginDialog.js b/js/gdm/loginDialog.js
index dac355f..adb5d55 100644
--- a/js/gdm/loginDialog.js
+++ b/js/gdm/loginDialog.js
@@ -506,11 +506,10 @@ const LoginDialog = new Lang.Class({
this._promptEntry.grab_key_focus();
- this._promptMessage = new St.Label({ visible: false });
+ this._promptMessage = new St.Label({ opacity: 0 });
this._promptBox.add(this._promptMessage, { x_fill: true });
this._promptLoginHint = new St.Label({ style_class: 'login-dialog-prompt-login-hint-message' });
- this._promptLoginHint.hide();
this._promptBox.add(this._promptLoginHint);
this._buttonBox = new St.BoxLayout({ style_class: 'modal-dialog-button-box',
@@ -641,7 +640,7 @@ const LoginDialog = new Lang.Class({
this._userVerifier.clear();
this._updateSensitivity(true);
- this._promptMessage.hide();
+ this._promptMessage.opacity = 0;
this._user = null;
this._verifyingUser = false;
@@ -728,20 +727,19 @@ const LoginDialog = new Lang.Class({
if (message) {
this._promptMessage.text = message;
this._promptMessage.styleClass = styleClass;
- this._promptMessage.show();
+ this._promptMessage.opacity = 255;
} else {
- this._promptMessage.hide();
+ this._promptMessage.opacity = 0;
}
},
_showLoginHint: function(verifier, message) {
this._promptLoginHint.set_text(message)
- this._promptLoginHint.show();
this._promptLoginHint.opacity = 255;
},
_hideLoginHint: function() {
- this._promptLoginHint.hide();
+ this._promptLoginHint.opacity = 0;
this._promptLoginHint.set_text('');
},
@@ -882,7 +880,7 @@ const LoginDialog = new Lang.Class({
this._setDefaultButtonWellMode(DefaultButtonWellMode.NONE, true);
this._promptBox.hide();
- this._promptLoginHint.hide();
+ this._promptLoginHint.opacity = 0;
this._promptUser.set_child(null);
@@ -890,7 +888,7 @@ const LoginDialog = new Lang.Class({
this._promptEntry.set_text('');
this._sessionMenuButton.close();
- this._promptLoginHint.hide();
+ this._promptLoginHint.opacity = 0;
this._buttonBox.remove_all_children();
this._signInButton = null;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]