[totem] main: Fixes height < 0 warnings



commit 7341be89f8ecee5f131756001d22838ac93e5245
Author: Alban Browaeys <prahal yahoo com>
Date:   Wed Jun 26 06:42:58 2013 +0200

    main: Fixes height < 0 warnings
    
    Show/realizes the main window after the video widget (and removes
    the realize of the bvw widget).
    
    Totem used to show the main window, minus the video widget, and then
    show the video widget so that any initialisation by the video widget
    (like registering plugins) would be done with the window visible.
    
    That's not the case anymore, so we might as well work around those
    problems by realizing the video widget in a big enough placeholder.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=703095

 src/totem-object.c |    1 -
 src/totem.c        |    6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/src/totem-object.c b/src/totem-object.c
index 3ce2fe4..51576ef 100644
--- a/src/totem-object.c
+++ b/src/totem-object.c
@@ -4068,7 +4068,6 @@ video_widget_create (TotemObject *totem)
        g_object_add_weak_pointer (G_OBJECT (totem->bvw),
                                   (gpointer *) bvw);
 
-       gtk_widget_realize (GTK_WIDGET (totem->bvw));
        gtk_widget_show (GTK_WIDGET (totem->bvw));
 
        totem_preferences_visuals_setup (totem);
diff --git a/src/totem.c b/src/totem.c
index 2c0ae53..ebfa473 100644
--- a/src/totem.c
+++ b/src/totem.c
@@ -115,6 +115,9 @@ app_init (Totem *totem, char **argv)
 
        sidebar_pageid = totem_setup_window (totem);
 
+       /* Show ! (again) the video widget this time. */
+       video_widget_create (totem);
+
        /* Show ! */
        if (optionstate.fullscreen == FALSE) {
                gtk_widget_show (totem->win);
@@ -125,9 +128,6 @@ app_init (Totem *totem, char **argv)
 
        totem->controls_visibility = TOTEM_CONTROLS_UNDEFINED;
 
-       /* Show ! (again) the video widget this time. */
-       video_widget_create (totem);
-
        totem->seek = g_object_get_data (totem->controls, "seek_scale");
        totem->seekadj = gtk_range_get_adjustment (GTK_RANGE (totem->seek));
        totem->volume = g_object_get_data (totem->controls, "volume_button");


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]