[gnumeric] Sheet Style: avoid incorrect unlinking of style dependents.
- From: Morten Welinder <mortenw src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnumeric] Sheet Style: avoid incorrect unlinking of style dependents.
- Date: Tue, 12 Feb 2013 00:20:21 +0000 (UTC)
commit 314faec3197633e108ca7e23b96b5c0f06b8a5d4
Author: Morten Welinder <terra gnome org>
Date: Sun Feb 10 13:53:05 2013 -0500
Sheet Style: avoid incorrect unlinking of style dependents.
I don't think there could be any that this point, but be safe.
ChangeLog | 5 +++++
src/sheet-style.c | 8 +++++---
2 files changed, 10 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 8de3248..1ed38e1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2013-02-10 Morten Welinder <terra gnome org>
+
+ * src/sheet-style.c (cb_unlink): gnm_style_unlink_dependents
+ doesn't belong here. We handle everything in rstyle_apply.
+
2013-02-08 Morten Welinder <terra gnome org>
* src/sheet-style.c (rstyle_apply): Take extra range argument and
diff --git a/src/sheet-style.c b/src/sheet-style.c
index 1911774..47aa441 100644
--- a/src/sheet-style.c
+++ b/src/sheet-style.c
@@ -441,6 +441,11 @@ static int tile_allocations = 0;
#endif
+/*
+ * Destroy a CellTile (recursively if needed). This will unlink all the
+ * styles in it. We do _not_ unlink style dependents here. That is done
+ * only in rstyle_apply.
+ */
static void
cell_tile_dtor (CellTile *tile)
{
@@ -735,9 +740,6 @@ static void
cb_unlink (void *key, G_GNUC_UNUSED void *value, G_GNUC_UNUSED void *user)
{
GnmStyle *style = key;
- GnmRange r;
- range_init_full_sheet (&r, style->linked_sheet);
- gnm_style_unlink_dependents (style, &r);
gnm_style_unlink (style);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]