[gedit] Fix bug destroying encodings combobox



commit 1686c431159b5eeaf404aab5775ac3d6744d26bc
Author: Ignacio Casal Quinteiro <icq gnome org>
Date:   Thu Apr 25 14:39:02 2013 +0200

    Fix bug destroying encodings combobox

 gedit/gedit-encodings-combo-box.c |    5 -----
 gedit/gedit-encodings-dialog.c    |    3 +--
 2 files changed, 1 insertions(+), 7 deletions(-)
---
diff --git a/gedit/gedit-encodings-combo-box.c b/gedit/gedit-encodings-combo-box.c
index 68db99e..ea5cfe1 100644
--- a/gedit/gedit-encodings-combo-box.c
+++ b/gedit/gedit-encodings-combo-box.c
@@ -186,11 +186,6 @@ dialog_response_cb (GtkDialog              *dialog,
        {
                update_menu (menu);
        }
-
-       if (response_id != GTK_RESPONSE_HELP)
-       {
-               gtk_widget_destroy (GTK_WIDGET (dialog));
-       }
 }
 
 static void
diff --git a/gedit/gedit-encodings-dialog.c b/gedit/gedit-encodings-dialog.c
index a6b297d..d4f206f 100644
--- a/gedit/gedit-encodings-dialog.c
+++ b/gedit/gedit-encodings-dialog.c
@@ -83,7 +83,6 @@ gedit_encodings_dialog_dispose (GObject *object)
        GeditEncodingsDialogPrivate *priv = GEDIT_ENCODINGS_DIALOG (object)->priv;
 
        g_clear_object (&priv->enc_settings);
-       g_message ("disposed");
 
        G_OBJECT_CLASS (gedit_encodings_dialog_parent_class)->dispose (object);
 }
@@ -115,7 +114,7 @@ gedit_encodings_dialog_response (GtkDialog *dialog,
                        g_strfreev (encs);
                }
                default:
-                       break;
+                       gtk_widget_destroy (GTK_WIDGET (dialog));
        }
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]