[network-manager-applet] gsm: fix a crash while getting PIN from a keyring (rh #950925)



commit 199ebe1e15a99da31e8c1ad3006df4df8d1d43fe
Author: Jiří Klimeš <jklimes redhat com>
Date:   Mon Apr 15 09:29:56 2013 +0200

    gsm: fix a crash while getting PIN from a keyring (rh #950925)
    
    secret_service_search_finish() can return an empty list without any error.

 src/applet-device-gsm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/applet-device-gsm.c b/src/applet-device-gsm.c
index 2bf1ae4..a647fca 100644
--- a/src/applet-device-gsm.c
+++ b/src/applet-device-gsm.c
@@ -811,10 +811,10 @@ keyring_pin_check_cb (GObject *source,
 
        list = secret_service_search_finish (NULL, result, &error);
 
-       if (error != NULL) {
+       if (!list) {
                /* No saved PIN, just ask the user */
                unlock_dialog_new (info->device, info);
-               g_error_free (error);
+               g_clear_error (&error);
                return;
        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]