[gnome-maps/goto-fixes: 2/2] mapLocation: Remove redudant workaround



commit 1dfcd278dcf0b6e1d4690bdbc9d5c24f0e7cc9ee
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date:   Wed Apr 17 18:54:37 2013 +0300

    mapLocation: Remove redudant workaround
    
    With following patch merged to libchamplain, we won't need this
    workaround:
    
    https://bugzilla.gnome.org/show_bug.cgi?id=698213

 src/mapLocation.js | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
---
diff --git a/src/mapLocation.js b/src/mapLocation.js
index ee19c6e..002a711 100644
--- a/src/mapLocation.js
+++ b/src/mapLocation.js
@@ -71,14 +71,9 @@ const MapLocation = new Lang.Class({
                 this._view.disconnect(animCompletedId);
                 animCompletedId = this._view.connect("animation-completed::go-to", Lang.bind(this,
                     function() {
-                        // Apparently the signal is called before animation is really complete so if we don't
-                        // zoom in idle, we get a crash. Perhaps a bug in libchamplain?
-                        Mainloop.idle_add(Lang.bind(this,
-                            function() {
-                                this._view.set_zoom_level(zoom);
-                                this.emit('gone-to');
-                            }));
                         this._view.disconnect(animCompletedId);
+                        this._view.set_zoom_level(zoom);
+                        this.emit('gone-to');
                     }));
                 this._view.go_to(this.latitude, this.longitude);
             }));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]