[file-roller] "Add Files" dialog crashes on i386 architecture



commit 1730f40db566e8ccf9a63861fb05f435105d7809
Author: Mitsuya Shibata <mty shibata gmail com>
Date:   Sat Sep 29 09:26:58 2012 +0200

    "Add Files" dialog crashes on i386 architecture
    
    Modified Order store GTimeVal.tv_sec[1]. GTimeVal.tv_sec is glong,
    but ui file[2] specify size as gint64. Therefore no problem on 64bit,
    on the other hand raise SEGV on 32bit by memory address boundary
    problem.
    
    Finally invalid address which is index of GtkListStore is passed
    to g_strdup() as memory address.
    
    This patch set same size storead size and allocated size.
    
    [1] see calling gtk_list_store_set() at get_folder_content_done_cb()
        in src/fr-file-selector-dialog.c
    [2] src/ui/file-selector.ui:296

 src/ui/file-selector.ui |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/ui/file-selector.ui b/src/ui/file-selector.ui
index 5241e36..fd0f2c0 100644
--- a/src/ui/file-selector.ui
+++ b/src/ui/file-selector.ui
@@ -293,7 +293,7 @@
       <!-- column-name size_order -->
       <column type="gint64"/>
       <!-- column-name modified_order -->
-      <column type="gint64"/>
+      <column type="glong"/>
       <!-- column-name is_folder -->
       <column type="gboolean"/>
       <!-- column-name is_selected -->



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]