[empathy] theme-adium: free the result of g_strsplit with g_strfreev
- From: Guillaume Desmottes <gdesmott src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [empathy] theme-adium: free the result of g_strsplit with g_strfreev
- Date: Thu, 13 Sep 2012 08:16:04 +0000 (UTC)
commit cb3a9fd4ae3bf0f74dabdfdd973898592a5f4244
Author: Guillaume Desmottes <guillaume desmottes collabora co uk>
Date: Wed Sep 12 15:06:28 2012 +0200
theme-adium: free the result of g_strsplit with g_strfreev
Freeing with g_free() doesn't free the content of the array.
https://bugzilla.gnome.org/show_bug.cgi?id=683864
libempathy-gtk/empathy-theme-adium.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/libempathy-gtk/empathy-theme-adium.c b/libempathy-gtk/empathy-theme-adium.c
index 194273d..2e243c4 100644
--- a/libempathy-gtk/empathy-theme-adium.c
+++ b/libempathy-gtk/empathy-theme-adium.c
@@ -1763,20 +1763,17 @@ empathy_adium_path_is_valid (const gchar *path)
/* The directory has to be *.AdiumMessageStyle per the Adium spec */
tmp = g_strsplit (path, "/", 0);
if (tmp == NULL)
- {
- g_free (tmp);
- return FALSE;
- }
+ return FALSE;
dir = tmp[g_strv_length (tmp) - 1];
if (!g_str_has_suffix (dir, ".AdiumMessageStyle"))
{
- g_free (tmp);
+ g_strfreev (tmp);
return FALSE;
}
- g_free (tmp);
+ g_strfreev (tmp);
/* The theme is not valid if there is no Info.plist */
file = g_build_filename (path, "Contents", "Info.plist",
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]