[evince] ev-page-action-widget: Use g_signal_connect instead of g_signal_connect_object
- From: Carlos Garcia Campos <carlosgc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evince] ev-page-action-widget: Use g_signal_connect instead of g_signal_connect_object
- Date: Sun, 18 Nov 2012 11:28:19 +0000 (UTC)
commit 30f23d66feb2f186d327bca3c02239e1b379c68f
Author: Carlos Garcia Campos <carlosgc gnome org>
Date: Sun Nov 18 12:25:19 2012 +0100
ev-page-action-widget: Use g_signal_connect instead of g_signal_connect_object
g_signal_connect_object has been finally fixed in recent versions of
glib, so the signal is disconnected when the object is disposed. However
we are manually disconnecting the signal handler, which gives a runtime
warning with recent glib versions because the signal has already been
disconnected. Use g_signal_connect() and keep disocnnecting the signal
manually to make sure it still works with previous versions of glib.
libmisc/ev-page-action-widget.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/libmisc/ev-page-action-widget.c b/libmisc/ev-page-action-widget.c
index 11d0dc2..23ec068 100644
--- a/libmisc/ev-page-action-widget.c
+++ b/libmisc/ev-page-action-widget.c
@@ -210,10 +210,10 @@ ev_page_action_widget_document_changed_cb (EvDocumentModel *model,
action_widget->signal_id = 0;
}
action_widget->signal_id =
- g_signal_connect_object (action_widget->doc_model,
- "page-changed",
- G_CALLBACK (page_changed_cb),
- action_widget, 0);
+ g_signal_connect (action_widget->doc_model,
+ "page-changed",
+ G_CALLBACK (page_changed_cb),
+ action_widget);
ev_page_action_widget_set_current_page (action_widget,
ev_document_model_get_page (model));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]