[gtksourceview] Do not keep weak pointer to the buffer



commit 1302cc4161fd206b9b3fcb55ca29442ec00bdcf8
Author: Paolo Borelli <pborelli gnome org>
Date:   Sat Nov 3 17:43:30 2012 +0100

    Do not keep weak pointer to the buffer
    
    It is up to GtkTextView to not emit extra notifications if the buffer is
    actually the same, so we do not need to keep a weak pointer just to
    check whether the buffer is the same.

 gtksourceview/gtksourcegutterrenderer.c |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)
---
diff --git a/gtksourceview/gtksourcegutterrenderer.c b/gtksourceview/gtksourcegutterrenderer.c
index e692f82..69ff56d 100644
--- a/gtksourceview/gtksourcegutterrenderer.c
+++ b/gtksourceview/gtksourcegutterrenderer.c
@@ -41,7 +41,6 @@ enum
 struct _GtkSourceGutterRendererPrivate
 {
 	GtkTextView *view;
-	GtkTextBuffer *buffer;
 	GtkTextWindowType window_type;
 
 	gint xpad;
@@ -92,20 +91,13 @@ static void
 emit_buffer_changed (GtkTextView             *view,
                      GtkSourceGutterRenderer *renderer)
 {
-	GtkTextBuffer* buffer;
+	GtkTextBuffer *buffer;
 
 	buffer = gtk_text_view_get_buffer (view);
 
-	if (buffer != renderer->priv->buffer)
+	if (GTK_SOURCE_GUTTER_RENDERER_GET_CLASS (renderer)->change_buffer)
 	{
-		if (GTK_SOURCE_GUTTER_RENDERER_GET_CLASS (renderer)->change_buffer)
-		{
-			GTK_SOURCE_GUTTER_RENDERER_GET_CLASS (renderer)->change_buffer (renderer,
-			                                                                renderer->priv->buffer);
-		}
-
-		renderer->priv->buffer = buffer;
-		g_object_add_weak_pointer (G_OBJECT (buffer), (gpointer)&renderer->priv->buffer);
+		GTK_SOURCE_GUTTER_RENDERER_GET_CLASS (renderer)->change_buffer (renderer, buffer);
 	}
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]