[goffice] modify last patch to place new items at the bottom
- From: Andreas J. Guelzow <guelzow src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [goffice] modify last patch to place new items at the bottom
- Date: Mon, 25 Jun 2012 19:24:22 +0000 (UTC)
commit 31c80050045f98d0866a6299c2a357ca3732d28c
Author: Andreas J Guelzow <aguelzow pyrshep ca>
Date: Mon Jun 25 13:23:45 2012 -0600
modify last patch to place new items at the bottom
2012-25-19 Andreas J. Guelzow <aguelzow pyrshep ca>
* plugins/reg_linear/gog-lin-reg.c (gog_lin_reg_curve_populate_editor):
place the new items at the bottom
* plugins/reg_linear/gog-polynom-reg.c
(gog_polynom_reg_curve_populate_editor): assume we are at the bottom,
so no row insertion is required.
ChangeLog | 8 ++++++++
plugins/reg_linear/gog-lin-reg.c | 9 +++------
plugins/reg_linear/gog-polynom-reg.c | 1 -
3 files changed, 11 insertions(+), 7 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 5ac562b..1c96355 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,14 @@
2012-25-19 Andreas J. Guelzow <aguelzow pyrshep ca>
* plugins/reg_linear/gog-lin-reg.c (gog_lin_reg_curve_populate_editor):
+ place the new items at the bottom
+ * plugins/reg_linear/gog-polynom-reg.c
+ (gog_polynom_reg_curve_populate_editor): assume we are at the bottom,
+ so no row insertion is required.
+
+2012-25-19 Andreas J. Guelzow <aguelzow pyrshep ca>
+
+ * plugins/reg_linear/gog-lin-reg.c (gog_lin_reg_curve_populate_editor):
fix item placement for pre-gtk-3.4.0
* plugins/reg_linear/gog-polynom-reg.c
(gog_polynom_reg_curve_populate_editor): ditto
diff --git a/plugins/reg_linear/gog-lin-reg.c b/plugins/reg_linear/gog-lin-reg.c
index 14eb811..31c07c1 100644
--- a/plugins/reg_linear/gog-lin-reg.c
+++ b/plugins/reg_linear/gog-lin-reg.c
@@ -164,13 +164,10 @@ gog_lin_reg_curve_populate_editor (GogRegCurve *reg_curve, gpointer table)
{
GtkWidget *sibling = GTK_WIDGET (g_object_get_data (table, "last-label"));
- if (sibling) {
- gtk_grid_insert_next_to (table, sibling, GTK_POS_BOTTOM);
+ if (sibling)
gtk_grid_attach_next_to (table, w, sibling, GTK_POS_BOTTOM, 1, 3);
- } else {
- gtk_grid_insert_row (table, 1);
- gtk_grid_attach (table, w, 0, 1, 3, 1);
- }
+ else
+ gtk_grid_attach (table, w, 0, 6, 3, 1);
g_object_set_data (G_OBJECT (table), "last-label", w);
}
#endif
diff --git a/plugins/reg_linear/gog-polynom-reg.c b/plugins/reg_linear/gog-polynom-reg.c
index adae422..86e7310 100644
--- a/plugins/reg_linear/gog-polynom-reg.c
+++ b/plugins/reg_linear/gog-polynom-reg.c
@@ -206,7 +206,6 @@ gog_polynom_reg_curve_populate_editor (GogRegCurve *reg_curve, gpointer table)
#if GTK_CHECK_VERSION(3,4,0)
gtk_grid_attach_next_to (table, l, NULL, GTK_POS_BOTTOM, 1, 1);
#else
- gtk_grid_insert_next_to (table, GTK_WIDGET (g_object_get_data (table, "last-label")), GTK_POS_BOTTOM);
gtk_grid_attach_next_to (table, l, GTK_WIDGET (g_object_get_data (table, "last-label")), GTK_POS_BOTTOM, 1, 1);
g_object_set_data (G_OBJECT (table), "last-label", l);
#endif
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]