[gegl/soc-2012-ops] Noise-hsv Operation

[Maxime Nicco <maxnicco src gnome org>]

commit 0cc74bf8f58d612c84d7459b79acb6e184a79284
Author: Maxime Nicco <maxime nicco gmail fr>
Date:   Fri Jul 27 11:33:22 2012 +0200

    Noise-hsv Operation
    
    Change to request format in prepare instead of convert in code.

 operations/common/noise-hsv.c |   39 ++++++++++++---------------------------
 1 files changed, 12 insertions(+), 27 deletions(-)
---
diff --git a/operations/common/noise-hsv.c b/operations/common/noise-hsv.c
index c0a90c5..69d523c 100644
--- a/operations/common/noise-hsv.c
+++ b/operations/common/noise-hsv.c
@@ -87,8 +87,8 @@ randomize_value (gfloat     now,
 
 static void prepare (GeglOperation *operation)
 {
-  gegl_operation_set_format (operation, "input", babl_format ("RGBA float"));
-  gegl_operation_set_format (operation, "output", babl_format ("RGBA float"));
+  gegl_operation_set_format (operation, "input", babl_format ("HSVA float"));
+  gegl_operation_set_format (operation, "output", babl_format ("HSVA float"));
 }
 
 static gboolean
@@ -102,34 +102,21 @@ process (GeglOperation       *operation,
   GeglChantO *o  = GEGL_CHANT_PROPERTIES (operation);
 
   gint i;
-  gfloat *out_pixel_ptr;
 
   gfloat   * GEGL_ALIGNED in_pixel;
-  gfloat   * GEGL_ALIGNED in_pixel_hsv;
-  gfloat   * GEGL_ALIGNED out_pixel_hsv;
   gfloat   * GEGL_ALIGNED out_pixel;
 
   gfloat    hue, saturation, value, alpha;
 
-  const Babl *hsva = babl_format ("HSVA float");
-  const Babl *rgba = babl_format ("RGBA float");
-
   in_pixel      = in_buf;
   out_pixel     = out_buf;
-  in_pixel_hsv  = g_slice_alloc (n_pixels * 4 * sizeof(gfloat));
-  out_pixel_hsv = g_slice_alloc (n_pixels * 4 * sizeof(gfloat));
-
-
-  babl_process (babl_fish (rgba, hsva), in_pixel, in_pixel_hsv, n_pixels);
-
-  out_pixel_ptr = out_pixel_hsv;
 
   for (i = 0; i < n_pixels; i++)
   {
-    hue        = in_pixel_hsv[0];
-    saturation = in_pixel_hsv[1];
-    value      = in_pixel_hsv[2];
-    alpha      = in_pixel_hsv[3];
+    hue        = in_pixel[0];
+    saturation = in_pixel[1];
+    value      = in_pixel[2];
+    alpha      = in_pixel[3];
 
     /* there is no need for scattering hue of desaturated pixels here */
     if ((o->hue_distance > 0) && (saturation > 0))
@@ -145,18 +132,16 @@ process (GeglOperation       *operation,
     if (o->value_distance > 0)
       value = randomize_value (value, 0.0, 1.0, FALSE, o->value_distance, o->holdness);
 
-      out_pixel_ptr[0] = hue;
-      out_pixel_ptr[1] = saturation;
-      out_pixel_ptr[2] = value;
-      out_pixel_ptr[3] = alpha;
+      out_pixel[0] = hue;
+      out_pixel[1] = saturation;
+      out_pixel[2] = value;
+      out_pixel[3] = alpha;
 
-    in_pixel_hsv  += 4;
-    out_pixel_ptr += 4;
+    in_pixel  += 4;
+    out_pixel += 4;
 
   }
 
-  babl_process (babl_fish (hsva, rgba), out_pixel_hsv, out_pixel, n_pixels);
-
   return TRUE;
 }