[gtk+] gtkspinbutton: Respect value of inherited 'editable' property



commit 3caa370bb5e3764aaf11b23d650c6233fc911854
Author: Zeeshan Ali (Khattak) <zeeshanak gnome org>
Date:   Wed Jan 4 00:44:24 2012 +0200

    gtkspinbutton: Respect value of inherited 'editable' property
    
    When this property is set to 'FALSE', user's click on the buttons
    should not actually update the value but rather result in error bell.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=667229

 gtk/gtkspinbutton.c |   16 +++++++++-------
 1 files changed, 9 insertions(+), 7 deletions(-)
---
diff --git a/gtk/gtkspinbutton.c b/gtk/gtkspinbutton.c
index 978109e..5a5cf80 100644
--- a/gtk/gtkspinbutton.c
+++ b/gtk/gtkspinbutton.c
@@ -1348,15 +1348,17 @@ gtk_spin_button_button_press (GtkWidget      *widget,
             gtk_widget_grab_focus (widget);
           priv->button = event->button;
 
-          if (gtk_editable_get_editable (GTK_EDITABLE (widget)))
+          if (gtk_editable_get_editable (GTK_EDITABLE (widget))) {
             gtk_spin_button_update (spin);
 
-          if (event->button == 1)
-            start_spinning (spin, event->window, gtk_adjustment_get_step_increment (priv->adjustment));
-          else if (event->button == 2)
-            start_spinning (spin, event->window, gtk_adjustment_get_page_increment (priv->adjustment));
-          else
-            priv->click_child = event->window;
+            if (event->button == 1)
+              start_spinning (spin, event->window, gtk_adjustment_get_step_increment (priv->adjustment));
+            else if (event->button == 2)
+              start_spinning (spin, event->window, gtk_adjustment_get_page_increment (priv->adjustment));
+            else
+              priv->click_child = event->window;
+          } else
+            gtk_widget_error_bell (widget);
 
           return TRUE;
         }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]