[glibmm] Gio::DBus::[ActionGroup|MenuModel]: Have get() and not create() methods.



commit a98cb0356c7e1c2f4121d6d87bca8a08c0cf7e0d
Author: Josà Alburquerque <jaalburqu svn gnome org>
Date:   Sun Feb 26 19:06:29 2012 -0500

    Gio::DBus::[ActionGroup|MenuModel]: Have get() and not create() methods.
    
    	* gio/src/dbusactiongroup.hg:
    	* gio/src/dbusmenumodel.hg: Have get() methods to get instances of
    	theses classes and not create() methods as is done in
    	Gio::Application.
    
    	Bug #637445.

 ChangeLog                  |   11 +++++++++++
 gio/src/dbusactiongroup.hg |    5 +----
 gio/src/dbusmenumodel.hg   |    5 +----
 3 files changed, 13 insertions(+), 8 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 86b3535..4a85299 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2012-02-26  Josà Alburquerque  <jaalburquerque gmail com>
+
+	Gio::DBus::[ActionGroup|MenuModel]: Have get() and not create() methods.
+
+	* gio/src/dbusactiongroup.hg:
+	* gio/src/dbusmenumodel.hg: Have get() methods to get instances of
+	theses classes and not create() methods as is done in
+	Gio::Application.
+
+	Bug #637445.
+
 2012-02-24  Murray Cumming  <murrayc murrayc com>
 
 	gmmproc: _WRAP_PROPERTY(): Allow properties to be deprecated.
diff --git a/gio/src/dbusactiongroup.hg b/gio/src/dbusactiongroup.hg
index 43e7a00..3872c1c 100644
--- a/gio/src/dbusactiongroup.hg
+++ b/gio/src/dbusactiongroup.hg
@@ -50,10 +50,7 @@ protected:
 
 public:
 #m4 _CONVERSION(`GDBusActionGroup*',`Glib::RefPtr<ActionGroup>',`Glib::wrap($3)')
-  //TODO: There should be a constructor and a _WRAP_CREATE instead of a
-  //_WRAP_METHOD.  It doesn't seem that GDBusActionGroup has the right
-  //properties for a constructor.
-  _WRAP_METHOD(static Glib::RefPtr<ActionGroup> create(const Glib::RefPtr<Connection>& connection, const Glib::ustring& bus_name, const Glib::ustring& object_path), g_dbus_action_group_get)
+  _WRAP_METHOD(static Glib::RefPtr<ActionGroup> get(const Glib::RefPtr<Connection>& connection, const Glib::ustring& bus_name, const Glib::ustring& object_path), g_dbus_action_group_get)
 };
 
 } // namespace DBus
diff --git a/gio/src/dbusmenumodel.hg b/gio/src/dbusmenumodel.hg
index 3a902bb..6ada9ed 100644
--- a/gio/src/dbusmenumodel.hg
+++ b/gio/src/dbusmenumodel.hg
@@ -45,10 +45,7 @@ protected:
 
 public:
 #m4 _CONVERSION(`GDBusMenuModel*',`Glib::RefPtr<MenuModel>',`Glib::wrap($3)')
-  //TODO: There should be a constructor and a _WRAP_CREATE instead of a
-  //_WRAP_METHOD.  Filing a Glib bug will probably be necessary so that it is
-  //possible to use g_object_new() to create a GDBusMenuModel.
-  _WRAP_METHOD(static Glib::RefPtr<MenuModel> create(const Glib::RefPtr<Connection>& connection, const Glib::ustring& bus_name, const Glib::ustring& object_path), g_dbus_menu_model_get)
+  _WRAP_METHOD(static Glib::RefPtr<MenuModel> get(const Glib::RefPtr<Connection>& connection, const Glib::ustring& bus_name, const Glib::ustring& object_path), g_dbus_menu_model_get)
 };
 
 } // namespace DBus



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]