[libsoup] soup-message-io: prevent a possible out-of-bounds memory access



commit 7a1bd2dc503d3f243b2caf3fa07b1c0e6f1c070c
Author: Dan Winship <danw gnome org>
Date:   Wed Feb 22 13:29:55 2012 -0500

    soup-message-io: prevent a possible out-of-bounds memory access

 libsoup/soup-message-io.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/libsoup/soup-message-io.c b/libsoup/soup-message-io.c
index 16eea04..cf2a2e3 100644
--- a/libsoup/soup-message-io.c
+++ b/libsoup/soup-message-io.c
@@ -316,12 +316,12 @@ read_metadata (SoupMessage *msg, gboolean to_blank)
 		if (got_lf) {
 			if (!to_blank)
 				break;
-			if (nread == 1 &&
+			if (nread == 1 && io->read_meta_buf->len >= 2 &&
 			    !strncmp ((char *)io->read_meta_buf->data +
 				      io->read_meta_buf->len - 2,
 				      "\n\n", 2))
 				break;
-			else if (nread == 2 &&
+			else if (nread == 2 && io->read_meta_buf->len >= 3 &&
 				 !strncmp ((char *)io->read_meta_buf->data +
 					   io->read_meta_buf->len - 3,
 					   "\n\r\n", 3))



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]