[gnumeric] ssdiff: eliminate more _get_entered_text calls.



commit b83cab2d3c894b05c1560d2277f69b7905a0c1fe
Author: Morten Welinder <terra gnome org>
Date:   Sat Dec 29 16:09:01 2012 -0500

    ssdiff: eliminate more _get_entered_text calls.

 ChangeLog    |    2 ++
 src/ssdiff.c |   10 ++--------
 2 files changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 2da2f32..66ea432 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,8 @@
 	(output_cell): New function taking proper care of value types,
 	convensions, etc.
 	(xml_cell_changed): Use output_cell.
+	(compare_corresponding_cells): Don't use entered_text here either,
+	although it's harmless.
 
 2012-12-28  Valek Filippov  <frob df ru>
 
diff --git a/src/ssdiff.c b/src/ssdiff.c
index a5c1bd6..5a87ab7 100644
--- a/src/ssdiff.c
+++ b/src/ssdiff.c
@@ -544,14 +544,8 @@ compare_corresponding_cells (GnmCell const *co, GnmCell const *cn)
 
 	if (has_expr != gnm_cell_has_expr (cn))
 		return TRUE;
-	if (has_expr) {
-		char *eo = gnm_cell_get_entered_text (co);
-		char *en = gnm_cell_get_entered_text (cn);
-		gboolean changed = !g_str_equal (co, cn);
-		g_free (eo);
-		g_free (en);
-		return changed;
-	}
+	if (has_expr)
+		return !gnm_expr_top_equal (co->base.texpr, cn->base.texpr);
 
 	if (has_value != (cn->value != NULL))
 		return TRUE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]