[gnome-shell] overview: Clean up overview code



commit e48dbe65f10ab6270d254da1c9e40314e73f0842
Author: Jasper St. Pierre <jstpierre mecheye net>
Date:   Mon Dec 10 03:58:59 2012 -0500

    overview: Clean up overview code
    
    The comment here is a liar. We certainly can handle failure
    using _syncInputMode().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=688589

 js/ui/overview.js |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/overview.js b/js/ui/overview.js
index da4dbae..7780e82 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -434,12 +434,11 @@ const Overview = new Lang.Class({
             return;
         if (this._shown)
             return;
-        // Do this manually instead of using _syncInputMode, to handle failure
-        if (!Main.pushModal(this._group, { keybindingMode: Main.KeybindingMode.OVERVIEW }))
+        this._shown = true;
+        this._syncInputMode();
+        if (!this._modal)
             return;
-        this._modal = true;
         this._animateVisible();
-        this._shown = true;
     },
 
     fadeInDesktop: function() {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]