[gnome-shell] overview: Fix stuck grabs when mashing the overlay-key
- From: Jasper St. Pierre <jstpierre src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] overview: Fix stuck grabs when mashing the overlay-key
- Date: Mon, 10 Dec 2012 19:39:07 +0000 (UTC)
commit 14fb51e6d7079abe81cccdaabf8221ff3283ec4c
Author: Jasper St. Pierre <jstpierre mecheye net>
Date: Sun Nov 18 10:49:31 2012 -0500
overview: Fix stuck grabs when mashing the overlay-key
When pressing the overlay key three times, things went like this:
* show(), push a modal
* hide(), will pop a modal after hiding is done
* show(), push a modal
Thus, when the showing is done, and then it activated the hiding,
it popped one modal, but not the other. This patch changes things
to be:
* show(), push a modal
* hide(), will pop a modal after hiding is done
* hide(), no-op
That is, mashing the overlay-key when it's showing will always make
it hide, not mashing an odd number of times.
https://bugzilla.gnome.org/show_bug.cgi?id=688589
js/ui/overview.js | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/overview.js b/js/ui/overview.js
index 9c91378..da4dbae 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -562,7 +562,7 @@ const Overview = new Lang.Class({
if (this.isDummy)
return;
- if (this._shown)
+ if (this.visible)
this.hide();
else
this.show();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]