[nemiver/monitor-variable: 4/4] Fix style and comments
- From: Dodji Seketeli <dodji src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nemiver/monitor-variable: 4/4] Fix style and comments
- Date: Sat, 14 Apr 2012 15:04:44 +0000 (UTC)
commit 3bb75ef2803c879a40a8e9f3f0ab87a65db9e451
Author: Dodji Seketeli <dodji seketeli org>
Date: Mon Mar 26 18:10:06 2012 +0200
Fix style and comments
* src/dbgengine/nmv-gdb-engine.cc
(OnListChangedVariableHandler::do_handle): Fix comments and add
some newlines.
* src/dbgengine/nmv-i-debugger.h (IDebugger::Variable::id): Fix
style.
src/dbgengine/nmv-gdb-engine.cc | 9 +++++++--
src/dbgengine/nmv-i-debugger.h | 6 +++++-
2 files changed, 12 insertions(+), 3 deletions(-)
---
diff --git a/src/dbgengine/nmv-gdb-engine.cc b/src/dbgengine/nmv-gdb-engine.cc
index b304843..1c281fb 100644
--- a/src/dbgengine/nmv-gdb-engine.cc
+++ b/src/dbgengine/nmv-gdb-engine.cc
@@ -2917,6 +2917,8 @@ struct OnListChangedVariableHandler : public OutputHandler
a_in.output ().result_record ().var_changes ();
IDebugger::VariableSafePtr variable = a_in.command ().variable ();
+ // This contains the sub-variables of 'variable' that changed,
+ // as well as 'variable' itself.
list<VariableSafePtr> changed_sub_vars;
// Each element of var_changes is either a change of variable
// itself, or a change of one its children. So apply those
@@ -2926,8 +2928,9 @@ struct OnListChangedVariableHandler : public OutputHandler
for (list<VarChangePtr>::const_iterator i = var_changes.begin ();
i != var_changes.end ();
++i) {
- // Apply the variable changes to each i->variable. The
- // result is going to be a list VariableSafePtr that is
+ // Apply each variable change to variable. The result is
+ // going to be a list of VariableSafePtr (variable itself,
+ // as well as each sub-variable that got changed) that is
// going to be sent back to notify the client code.
(*i)->apply_to_variable (variable, changed_sub_vars);
LOG_DD ("Num sub vars:" << (int) changed_sub_vars.size ());
@@ -2942,6 +2945,7 @@ struct OnListChangedVariableHandler : public OutputHandler
vars.push_back (*j);
}
}
+
// Call the slot associated to
// IDebugger::list_changed_variables(), if any.
if (a_in.command ().has_slot ()) {
@@ -2951,6 +2955,7 @@ struct OnListChangedVariableHandler : public OutputHandler
SlotType slot = a_in.command ().get_slot<SlotType> ();
slot (vars);
}
+
// Tell the world about the descendant variables that changed.
m_engine->changed_variables_signal ().emit
(vars, a_in.command ().cookie ());
diff --git a/src/dbgengine/nmv-i-debugger.h b/src/dbgengine/nmv-i-debugger.h
index 149b82e..4ce41e8 100644
--- a/src/dbgengine/nmv-i-debugger.h
+++ b/src/dbgengine/nmv-i-debugger.h
@@ -621,7 +621,11 @@ public:
/// (e.g. variable object in GDB).
/// \param a_in the new name of backend side counterpart variable object.
void internal_name (const UString &a_in) {m_internal_name = a_in;}
- const UString& id () const { return internal_name ().empty () ? name () : internal_name ();}
+ const UString& id () const
+ { return internal_name ().empty ()
+ ? name ()
+ : internal_name ();
+ }
IDebugger* debugger () const {return m_debugger;}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]