[glom] Remove the Add Related Table feature.



commit 18c4e7847a6763b3de686ef5606d1fde74ec789e
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Sep 13 09:33:56 2011 +0200

    Remove the Add Related Table feature.
    
    * glom/application.cc: init_menus():
    * glom/frame_glom.[h|cc]: on_menu_Tables_AddRelatedTable(): Remove the
    Tables/Add Related Table menu item (and feature) because, though it is
    useful, it requires explanation and is probably confusing to new users.
    
    Of course you can still add tables and then a relationship to them manually.

 ChangeLog           |   11 +++++++++++
 glom/application.cc |    4 ++++
 glom/frame_glom.cc  |    2 ++
 glom/frame_glom.h   |   11 ++++-------
 4 files changed, 21 insertions(+), 7 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 47f9c1f..f885582 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2011-09-13  Murray Cumming  <murrayc murrayc com>>
+
+	Remove the Add Related Table feature.
+
+	* glom/application.cc: init_menus():
+	* glom/frame_glom.[h|cc]: on_menu_Tables_AddRelatedTable(): Remove the 
+	Tables/Add Related Table menu item (and feature) because, though it is 
+	useful, it requires explanation and is probably confusing to new users.
+	
+	Of course you can still add tables and then a relationship to them manually.
+
 1.19.10:
 
 2011-09-12  Murray Cumming  <murrayc murrayc com>
diff --git a/glom/application.cc b/glom/application.cc
index d65686d..25f3c6e 100644
--- a/glom/application.cc
+++ b/glom/application.cc
@@ -386,10 +386,12 @@ void Application::init_menus()
                         sigc::mem_fun(*m_pFrame, &Frame_Glom::on_menu_Tables_EditTables) );
   m_listDeveloperActions.push_back(action);
 
+/* Commented out because it is useful but confusing to new users:
   action = Gtk::Action::create("GlomAction_Menu_AddRelatedTable", _("Add _Related Table"));
   m_refActionGroup_Others->add(action,
                         sigc::mem_fun(*m_pFrame, &Frame_Glom::on_menu_Tables_AddRelatedTable) );
   m_listDeveloperActions.push_back(action);
+*/
 #endif // !GLOM_ENABLE_CLIENT_ONLY
 
   //"Reports" menu:
@@ -545,7 +547,9 @@ void Application::init_menus()
     "        <separator />"
 #ifndef GLOM_ENABLE_CLIENT_ONLY
     "        <menuitem action='GlomAction_Menu_EditTables' />"
+/* Commented out because it is useful but confusing to new users:
     "        <menuitem action='GlomAction_Menu_AddRelatedTable' />"
+*/
 #endif // !GLOM_ENABLE_CLIENT_ONLY
     "     </menu>"
     "     <menu action='Glom_Menu_Reports'>"
diff --git a/glom/frame_glom.cc b/glom/frame_glom.cc
index ccba961..ff5e1e7 100644
--- a/glom/frame_glom.cc
+++ b/glom/frame_glom.cc
@@ -1088,6 +1088,7 @@ void Frame_Glom::on_menu_Tables_EditTables()
   do_menu_Navigate_Table();
 }
 
+/* Commented out because it is useful but confusing to new users:
 void Frame_Glom::on_menu_Tables_AddRelatedTable()
 {
   //Delete and recreate the dialog,
@@ -1118,6 +1119,7 @@ void Frame_Glom::on_menu_Tables_AddRelatedTable()
   m_dialog_addrelatedtable->set_modal(); //We don't want people to edit the main window while we are changing structure.
   m_dialog_addrelatedtable->show();
 }
+*/
 
 #endif
 
diff --git a/glom/frame_glom.h b/glom/frame_glom.h
index 6242275..40288cc 100644
--- a/glom/frame_glom.h
+++ b/glom/frame_glom.h
@@ -95,18 +95,15 @@ public:
 
   void on_menu_report_selected(const Glib::ustring& report_name);
 
-#ifndef GLOM_ENABLE_CLIENT_ONLY
-  void on_menu_print_layout_selected(const Glib::ustring& print_layout_name);
-#endif // !GLOM_ENABLE_CLIENT_ONLY
-
-  //virtual void on_menu_Navigate_Database();
-  //virtual void do_menu_Navigate_Database(bool bUseList = true);
-
   void do_menu_Navigate_Table(bool open_default = false);
 
 #ifndef GLOM_ENABLE_CLIENT_ONLY
+  void on_menu_print_layout_selected(const Glib::ustring& print_layout_name);
   void on_menu_Tables_EditTables();
+
+/* Commented out because it is useful but confusing to new users:
   void on_menu_Tables_AddRelatedTable();
+*/
 #endif // !GLOM_ENABLE_CLIENT_ONLY
 
 #ifndef GLOM_ENABLE_CLIENT_ONLY



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]