[gtk+] rbtree: Remove the nil member
- From: Benjamin Otte <otte src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] rbtree: Remove the nil member
- Date: Tue, 22 Nov 2011 02:51:40 +0000 (UTC)
commit 37786804e185534f35c289be695f0cb21d4a87b4
Author: Benjamin Otte <otte redhat com>
Date: Tue Nov 22 03:18:31 2011 +0100
rbtree: Remove the nil member
gtk/gtkrbtree.c | 15 ++++++---------
gtk/gtkrbtree.h | 1 -
gtk/tests/rbtree.c | 2 --
3 files changed, 6 insertions(+), 12 deletions(-)
---
diff --git a/gtk/gtkrbtree.c b/gtk/gtkrbtree.c
index 6304ee8..a1f93f6 100644
--- a/gtk/gtkrbtree.c
+++ b/gtk/gtkrbtree.c
@@ -61,9 +61,9 @@ _gtk_rbnode_new (GtkRBTree *tree,
{
GtkRBNode *node = g_slice_new (GtkRBNode);
- node->left = tree->nil;
- node->right = tree->nil;
- node->parent = tree->nil;
+ node->left = (GtkRBNode *) &nil;
+ node->right = (GtkRBNode *) &nil;
+ node->parent = (GtkRBNode *) &nil;
node->flags = GTK_RBNODE_RED;
node->total_count = 1;
node->count = 1;
@@ -357,9 +357,8 @@ _gtk_rbtree_new (void)
retval->parent_tree = NULL;
retval->parent_node = NULL;
- retval->nil = (GtkRBNode *) &nil;
+ retval->root = (GtkRBNode *) &nil;
- retval->root = retval->nil;
return retval;
}
@@ -473,11 +472,11 @@ _gtk_rbtree_insert_after (GtkRBTree *tree,
}
/* setup new node */
node = _gtk_rbnode_new (tree, height);
- node->parent = (current?current:tree->nil);
/* insert node in tree */
if (current)
{
+ node->parent = current;
if (right)
current->right = node;
else
@@ -541,11 +540,11 @@ _gtk_rbtree_insert_before (GtkRBTree *tree,
/* setup new node */
node = _gtk_rbnode_new (tree, height);
- node->parent = (current?current:tree->nil);
/* insert node in tree */
if (current)
{
+ node->parent = current;
if (left)
current->left = node;
else
@@ -1666,8 +1665,6 @@ _gtk_rbtree_test (const gchar *where,
while (tmp_tree->parent_tree)
tmp_tree = tmp_tree->parent_tree;
- g_assert (tmp_tree->nil != NULL);
-
if (_gtk_rbtree_is_nil (tmp_tree->root))
return;
diff --git a/gtk/gtkrbtree.h b/gtk/gtkrbtree.h
index 293f7ba..173b141 100644
--- a/gtk/gtkrbtree.h
+++ b/gtk/gtkrbtree.h
@@ -57,7 +57,6 @@ typedef void (*GtkRBTreeTraverseFunc) (GtkRBTree *tree,
struct _GtkRBTree
{
GtkRBNode *root;
- GtkRBNode *nil;
GtkRBTree *parent_tree;
GtkRBNode *parent_node;
};
diff --git a/gtk/tests/rbtree.c b/gtk/tests/rbtree.c
index 7e51509..dfcc732 100644
--- a/gtk/tests/rbtree.c
+++ b/gtk/tests/rbtree.c
@@ -213,8 +213,6 @@ _gtk_rbtree_test (GtkRBTree *tree)
while (tmp_tree->parent_tree)
tmp_tree = tmp_tree->parent_tree;
- g_assert (tmp_tree->nil != NULL);
-
if (_gtk_rbtree_is_nil (tmp_tree->root))
return;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]