[gconf-editor] Rename "type" property of GConfEditorWindow



commit 4c11c1095b43c7ec44d19d78e9ef8f0248cfa8ef
Author: Christian Persch <chpe gnome org>
Date:   Tue Nov 8 15:32:59 2011 +0100

    Rename "type" property of GConfEditorWindow
    
    GtkWindow already has a "type" property, which this one conflicts with;
    and gail was trying to get this property on focus changes:
    
    GLib-GObject-WARNING **: g_object_get_valist: property `type' of object class `GConfEditorWindow' is not readable
    g_logv() [gmessages.c:779]
    g_log() [gmessages.c:826]
    g_object_get_valist() [gobject.c:1789]
    g_object_get() [gobject.c:1886]
    gail_focus_watcher() [gail.c:159]
    signal_emit_unlocked_R() [gsignal.c:3239]
    
    Also make the property readable, since the get_property implementation already
    supports that.

 src/gconf-editor-application.c |    2 +-
 src/gconf-editor-window.c      |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/gconf-editor-application.c b/src/gconf-editor-application.c
index fc37105..47ace0a 100644
--- a/src/gconf-editor-application.c
+++ b/src/gconf-editor-application.c
@@ -43,7 +43,7 @@ gconf_editor_application_create_editor_window (int type)
 	GtkWidget *window;
 	GConfEditorWindow *gconfwindow;
 
-	window = g_object_new (GCONF_TYPE_EDITOR_WINDOW, "type", type, NULL);
+	window = g_object_new (GCONF_TYPE_EDITOR_WINDOW, "editor-type", type, NULL);
 
 	gconfwindow = GCONF_EDITOR_WINDOW (window);
 
diff --git a/src/gconf-editor-window.c b/src/gconf-editor-window.c
index 4f51c8b..804229f 100644
--- a/src/gconf-editor-window.c
+++ b/src/gconf-editor-window.c
@@ -1418,12 +1418,12 @@ gconf_editor_window_class_init (GConfEditorWindowClass *klass)
 	object_class->finalize = gconf_editor_window_finalize;
 
 	g_object_class_install_property (object_class, PROP_TYPE,
-					 g_param_spec_int ("type",
+					 g_param_spec_int ("editor-type",
 					 "Type",
 					 "The Configuration Editor window type.",
 					 GCONF_EDITOR_WINDOW_TYPE_NORMAL, GCONF_EDITOR_WINDOW_TYPE_MANDATORY,
 					 GCONF_EDITOR_WINDOW_TYPE_NORMAL, 
-					 (G_PARAM_WRITABLE |
+					 (G_PARAM_READWRITE |
 					 G_PARAM_CONSTRUCT_ONLY)));
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]