[vinagre] Remove broken gtk-vnc log handler, bug 632711
- From: David King <davidk src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vinagre] Remove broken gtk-vnc log handler, bug 632711
- Date: Sat, 19 Mar 2011 20:27:20 +0000 (UTC)
commit a4d472052a9515448889d7f76640a6675b294ebd
Author: David King <amigadave amigadave com>
Date: Sat Mar 19 21:22:07 2011 +0100
Remove broken gtk-vnc log handler, bug 632711
The custom logging handler for gtk-vnc debugging output used printf()
for output. Thus, the output was buffered and could appear out-of-order
with other debug messages. Removing the custom handler ensures that the
default gtk-vnc handler is used. Thanks to Daniel P. Berrange for the
report.
vinagre/vinagre-main.c | 2 --
vinagre/vinagre-utils.c | 24 ------------------------
vinagre/vinagre-utils.h | 2 --
3 files changed, 0 insertions(+), 28 deletions(-)
---
diff --git a/vinagre/vinagre-main.c b/vinagre/vinagre-main.c
index 134a190..08e23bd 100644
--- a/vinagre/vinagre-main.c
+++ b/vinagre/vinagre-main.c
@@ -67,8 +67,6 @@ app_init (GtkApplication *app)
gtk_window_set_application (window, app);
gtk_widget_show (GTK_WIDGET (window));
- vinagre_utils_handle_debug ();
-
#ifdef VINAGRE_HAVE_TELEPATHY_GLIB
vinagre_tubes_manager = vinagre_tubes_manager_new (VINAGRE_WINDOW (window));
#endif
diff --git a/vinagre/vinagre-utils.c b/vinagre/vinagre-utils.c
index ff587c5..1739d64 100644
--- a/vinagre/vinagre-utils.c
+++ b/vinagre/vinagre-utils.c
@@ -217,30 +217,6 @@ vinagre_utils_escape_underscores (const gchar* text,
return g_string_free (str, FALSE);
}
-static void _default_log (const gchar *log_domain G_GNUC_UNUSED,
- GLogLevelFlags log_level G_GNUC_UNUSED,
- const gchar *message,
- gpointer user_data G_GNUC_UNUSED)
-{
- printf ("gtk-vnc: %s\n", message);
-}
-
-void
-vinagre_utils_handle_debug (void)
-{
- static gboolean initialized = FALSE;
-
- if (initialized)
- return;
-
- g_log_set_handler ("gtk-vnc",
- G_LOG_LEVEL_DEBUG,
- _default_log,
- NULL);
-
- initialized = TRUE;
-}
-
void
vinagre_utils_help_contents (GtkWindow *window, const gchar *section)
{
diff --git a/vinagre/vinagre-utils.h b/vinagre/vinagre-utils.h
index 72654ec..d964828 100644
--- a/vinagre/vinagre-utils.h
+++ b/vinagre/vinagre-utils.h
@@ -50,8 +50,6 @@ GtkBuilder *vinagre_utils_get_builder (const gchar *filename);
gchar *vinagre_utils_escape_underscores (const gchar *text,
gssize length);
-void vinagre_utils_handle_debug (void);
-
void vinagre_utils_help_contents (GtkWindow *window, const gchar *section);
void vinagre_utils_help_about (GtkWindow *window);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]