[gimp] app: don't PAUSE/RESUME the active tool around sending it motion events



commit d784ca0a59aaefd2ee7d3e2f908e57d0492717a3
Author: Michael Natterer <mitch gimp org>
Date:   Sun Apr 17 21:12:02 2011 +0200

    app: don't PAUSE/RESUME the active tool around sending it motion events
    
    That's most likely a very old artifact that was needed not even when
    we used to do XOR, and these days it's even wrong because it makes
    the tools think that something about the display has changed, like
    zoom or scroll.

 app/display/gimpdisplayshell-tool-events.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)
---
diff --git a/app/display/gimpdisplayshell-tool-events.c b/app/display/gimpdisplayshell-tool-events.c
index c10defa..a1c59b4 100644
--- a/app/display/gimpdisplayshell-tool-events.c
+++ b/app/display/gimpdisplayshell-tool-events.c
@@ -909,9 +909,6 @@ gimp_display_shell_canvas_tool_events (GtkWidget        *canvas,
 
                     device = gimp_device_info_get_by_device (mevent->device);
 
-                    tool_manager_control_active (gimp, GIMP_TOOL_ACTION_PAUSE,
-                                                 display);
-
                     for (i = 0; i < n_history_events; i++)
                       {
                         gimp_device_info_get_time_coords (device,
@@ -938,9 +935,6 @@ gimp_display_shell_canvas_tool_events (GtkWidget        *canvas,
                           }
                       }
 
-                    tool_manager_control_active (gimp, GIMP_TOOL_ACTION_RESUME,
-                                                 display);
-
                     gdk_device_free_history (history_events, n_history_events);
                   }
                 else
@@ -1788,9 +1782,6 @@ gimp_display_shell_process_event_queue (GimpDisplayShell *shell,
 
   shell->motion_buffer->last_active_state = state;
 
-  tool_manager_control_active (shell->display->gimp,
-                               GIMP_TOOL_ACTION_PAUSE, shell->display);
-
   while (shell->motion_buffer->event_queue->len > keep)
     {
       GimpCoords buf_coords;
@@ -1805,9 +1796,6 @@ gimp_display_shell_process_event_queue (GimpDisplayShell *shell,
                                   shell->display);
     }
 
-  tool_manager_control_active (shell->display->gimp,
-                               GIMP_TOOL_ACTION_RESUME, shell->display);
-
   if (shell->motion_buffer->event_delay)
     {
       shell->motion_buffer->event_delay_timeout =



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]