[gnome-shell] network: fix logic bug in checking whether to activate or deactive



commit 6c3300bc2f196c76b17ccd78804a9f2aabaff48e
Author: Owen W. Taylor <otaylor fishsoup net>
Date:   Sat Apr 2 15:05:06 2011 -0400

    network: fix logic bug in checking whether to activate or deactive
    
    A cosmetic change recommended in review of the patch to fix the
    VPN Connections switch ended up introducing a logic error that
    made the switch not work properly. Fix.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=646380

 js/ui/status/network.js |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index 7616542..c78b08b 100644
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -254,12 +254,14 @@ NMWiredSectionTitleMenuItem.prototype = {
             return;
         }
 
+        let newState = this._switch.state;
+
         // Immediately reset the switch to false, it will be updated appropriately
         // by state-changed signals in devices (but fixes the VPN not being in sync
         // if the ActiveConnection object is never seen by libnm-glib)
         this._switch.setToggleState(false);
 
-        if (this._switch.state)
+        if (newState)
             this._device.activate();
         else
             this._device.deactivate();



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]