[evolution-data-server] Bug 630149 - imapx_sync() never returns error



commit c217ff77d44969014d6fe8ccf4ed366497aa907a
Author: David Woodhouse <David Woodhouse intel com>
Date:   Mon Sep 20 13:29:20 2010 +0100

    Bug 630149 - imapx_sync() never returns error

 camel/providers/imapx/camel-imapx-folder.c |   17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-folder.c b/camel/providers/imapx/camel-imapx-folder.c
index e79f389..e3cfa03 100644
--- a/camel/providers/imapx/camel-imapx-folder.c
+++ b/camel/providers/imapx/camel-imapx-folder.c
@@ -225,19 +225,20 @@ imapx_sync (CamelFolder *folder, gboolean expunge, GError **error)
 		return FALSE;
 	}
 
-	server = camel_imapx_store_get_server (istore, camel_folder_get_full_name (folder), NULL);
-	if (server)
-		camel_imapx_server_sync_changes (server, folder, NULL);
+	server = camel_imapx_store_get_server (istore, camel_folder_get_full_name (folder), error);
+	if (!server)
+		return FALSE;
+
+	camel_imapx_server_sync_changes (server, folder, NULL);
 
 	/* Sync twice - make sure deleted flags are written out,
 	   then sync again incase expunge changed anything */
 
-	if (server && expunge)
+	if (expunge)
 		camel_imapx_server_expunge (server, folder, NULL);
-	if (server) {
-		camel_imapx_store_op_done (istore, server, camel_folder_get_full_name (folder));
-		g_object_unref (server);
-	}
+
+	camel_imapx_store_op_done (istore, server, camel_folder_get_full_name (folder));
+	g_object_unref (server);
 
 	return TRUE;
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]