[libdmapsharing] Small changes after reviewing code Signed-off-by: W. Michael Petullo <mike flyn org>

[W. Michael Petullo <wmpetullo src gnome org>]

commit f8923d2749341533c80d058fb1b62fef0d3bcbd4
Author: W. Michael Petullo <mike flyn org>
Date:   Fri Oct 1 15:53:05 2010 -0500

    Small changes after reviewing code
    Signed-off-by: W. Michael Petullo <mike flyn org>

 TODO                                     |   10 ++++++++++
 libdmapsharing/daap-record.c             |    2 +-
 libdmapsharing/daap-share.c              |    2 +-
 libdmapsharing/dmap-mdns-browser-avahi.c |    2 +-
 libdmapsharing/dmap-structure.c          |    1 -
 5 files changed, 13 insertions(+), 4 deletions(-)
---
diff --git a/TODO b/TODO
index baa5318..0865f69 100644
--- a/TODO
+++ b/TODO
@@ -1,5 +1,15 @@
 Fix DNSSD on Mac OS X
 
+Audit remaining GSoC patch:
+--- dmap-db.c
+--- dmap-share.c
+--- dacp-player.c
+--- dacp-player.h
+--- dacp-share.c
+--- dacp-share.h
+
+Does, e.g., handle_server_info need user_data parameter?
+
 Complete DACP code and push Rhythmbox patch
 
 Reduce the memory usage while building response to media list query.
diff --git a/libdmapsharing/daap-record.c b/libdmapsharing/daap-record.c
index 5bc514f..8aeed10 100644
--- a/libdmapsharing/daap-record.c
+++ b/libdmapsharing/daap-record.c
@@ -44,7 +44,7 @@ daap_record_init (DAAPRecordInterface *iface)
 					     "Unknown",
 					     G_PARAM_READWRITE));
 
-		//FIXME: This is actually an enum
+		/* FIXME: This is actually an enum */
 		g_object_interface_install_property (iface,
 			g_param_spec_int ("mediakind",
 			                  "Media kind",
diff --git a/libdmapsharing/daap-share.c b/libdmapsharing/daap-share.c
index e24ac53..7e4d53b 100644
--- a/libdmapsharing/daap-share.c
+++ b/libdmapsharing/daap-share.c
@@ -809,7 +809,7 @@ databases_browse_xxx (DMAPShare *share,
 	node = dmap_structure_add (abro, category_cc);
 
 	values = g_hash_table_get_keys (category_items);
-	if (g_hash_table_lookup (query, "include-sort-headers")) {
+	if (values && g_hash_table_lookup (query, "include-sort-headers")) {
 		g_debug ("Sorting...");
 		values = g_list_sort (values, (GCompareFunc) g_ascii_strcasecmp);
 	}
diff --git a/libdmapsharing/dmap-mdns-browser-avahi.c b/libdmapsharing/dmap-mdns-browser-avahi.c
index 87c367a..3d0f0d6 100644
--- a/libdmapsharing/dmap-mdns-browser-avahi.c
+++ b/libdmapsharing/dmap-mdns-browser-avahi.c
@@ -373,7 +373,7 @@ resolve_cb (AvahiServiceResolver *service_resolver,
 {
     if (event == AVAHI_RESOLVER_FOUND) {
         gchar *name = NULL;
-        gchar *pair = NULL;
+        gchar *pair = NULL; /* FIXME: extract DACP-specific items into sub-class? See also howl code. */
         gchar host[AVAHI_ADDRESS_STR_MAX];
         gboolean pp = FALSE;
         DMAPMdnsBrowserService *service;
diff --git a/libdmapsharing/dmap-structure.c b/libdmapsharing/dmap-structure.c
index 6377409..aaf6fac 100644
--- a/libdmapsharing/dmap-structure.c
+++ b/libdmapsharing/dmap-structure.c
@@ -389,7 +389,6 @@ dmap_structure_parse_container_buffer (GNode *parent,
         
         cc = dmap_content_code_read_from_buffer ((const gchar*)&(buf[l]));
         if (cc == DMAP_CC_INVALID) {
-            //g_debug ("Invalid/Unknown content_code recieved\n");
             return;
         }
         l += 4;