[at-spi2-core] Fix functions missing return values
- From: Mike Gorse <mgorse src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [at-spi2-core] Fix functions missing return values
- Date: Tue, 25 May 2010 22:44:22 +0000 (UTC)
commit 6690fa2d6fbbe211a2abf304e791aa0563d92399
Author: Mike Gorse <mgorse novell com>
Date: Tue May 25 18:44:27 2010 -0400
Fix functions missing return values
registryd/registry.c | 24 ++++++++++++++----------
1 files changed, 14 insertions(+), 10 deletions(-)
---
diff --git a/registryd/registry.c b/registryd/registry.c
index 6ff094b..f3728f8 100644
--- a/registryd/registry.c
+++ b/registryd/registry.c
@@ -30,13 +30,13 @@
#include "registry.h"
#include "introspection.h"
-static gboolean
+static void
children_added_listener (DBusConnection * bus,
gint index,
const gchar * name,
const gchar * path);
-static gboolean
+static void
children_removed_listener (DBusConnection * bus,
gint index,
const gchar * name,
@@ -95,22 +95,26 @@ return_v_string (DBusMessageIter * iter, const gchar * str)
{
DBusMessageIter variant;
- dbus_message_iter_open_container (iter, DBUS_TYPE_VARIANT, "s",
- &variant);
+ if (!dbus_message_iter_open_container (iter, DBUS_TYPE_VARIANT, "s",
+ &variant))
+ return FALSE;
dbus_message_iter_append_basic (&variant, DBUS_TYPE_STRING, &str);
dbus_message_iter_close_container (iter, &variant);
+ return TRUE;
}
-static void
+static dbus_bool_t
append_reference (DBusMessageIter * iter, const char * name, const char * path)
{
DBusMessageIter iter_struct;
- dbus_message_iter_open_container (iter, DBUS_TYPE_STRUCT, NULL,
- &iter_struct);
+ if (!dbus_message_iter_open_container (iter, DBUS_TYPE_STRUCT, NULL,
+ &iter_struct))
+ return FALSE;
dbus_message_iter_append_basic (&iter_struct, DBUS_TYPE_STRING, &name);
dbus_message_iter_append_basic (&iter_struct, DBUS_TYPE_OBJECT_PATH, &path);
dbus_message_iter_close_container (iter, &iter_struct);
+ return TRUE;
}
/*---------------------------------------------------------------------------*/
@@ -466,7 +470,7 @@ impl_get_ChildCount (DBusMessageIter * iter, void *user_data)
SpiRegistry *reg = SPI_REGISTRY (user_data);
dbus_int32_t rv = reg->apps->len;
- dbus_message_iter_append_basic (iter, DBUS_TYPE_INT32, &rv);
+ return dbus_message_iter_append_basic (iter, DBUS_TYPE_INT32, &rv);
}
static DBusMessage *
@@ -774,7 +778,7 @@ emit_event (DBusConnection *bus,
* any_data is the child reference.
*/
-static gboolean
+static void
children_added_listener (DBusConnection * bus,
gint index,
const gchar * name,
@@ -784,7 +788,7 @@ children_added_listener (DBusConnection * bus,
name, path);
}
-static gboolean
+static void
children_removed_listener (DBusConnection * bus,
gint index,
const gchar * name,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]