[eog] Have the ThumbNav's scrollbuttons bound to the GSettings key

[Felix Riemann <friemann src gnome org>]

commit 0a898703a9a19589e049a73d21c91898b0dbc51e
Author: Felix Riemann <friemann gnome org>
Date:   Sat Jun 26 17:19:06 2010 +0200

    Have the ThumbNav's scrollbuttons bound to the GSettings key
    
    One signal callback less in EogWindow.
    The setting is not updated on changes to the property (eg. by plugins).

 src/eog-window.c |   31 ++++---------------------------
 1 files changed, 4 insertions(+), 27 deletions(-)
---
diff --git a/src/eog-window.c b/src/eog-window.c
index 7615f16..01d5a7e 100644
--- a/src/eog-window.c
+++ b/src/eog-window.c
@@ -386,28 +386,6 @@ eog_window_trans_color_changed_cb (GSettings *settings,
 }
 
 static void
-eog_window_scroll_buttons_changed_cb (GSettings *settings,
-				      gchar     *key,
-				      gpointer   user_data)
-{
-	EogWindowPrivate *priv;
-	gboolean show_buttons = TRUE;
-
-	eog_debug (DEBUG_PREFERENCES);
-
-	g_return_if_fail (EOG_IS_WINDOW (user_data));
-
-	priv = EOG_WINDOW (user_data)->priv;
-
-	g_return_if_fail (EOG_IS_SCROLL_VIEW (priv->view));
-
-	show_buttons = g_settings_get_boolean (settings, key);
-
-	eog_thumb_nav_set_show_buttons (EOG_THUMB_NAV (priv->nav),
-					show_buttons);
-}
-
-static void
 eog_window_gallery_mode_changed_cb (GSettings *settings,
 				    gchar     *key,
 				    gpointer   user_data)
@@ -4394,6 +4372,10 @@ eog_window_construct_ui (EogWindow *window)
 				       g_settings_get_boolean (priv->ui_settings
 				       	, EOG_CONF_UI_SCROLL_BUTTONS));
 
+	// Bind the scroll buttons to their GSettings key
+	g_settings_bind (priv->ui_settings, EOG_CONF_UI_SCROLL_BUTTONS,
+			 priv->nav, "show-buttons", G_SETTINGS_BIND_GET);
+
 	thumb_popup = gtk_ui_manager_get_widget (priv->ui_mgr, "/ThumbnailPopup");
 	eog_thumb_view_set_thumbnail_popup (EOG_THUMB_VIEW (priv->thumbview),
 					    GTK_MENU (thumb_popup));
@@ -4495,11 +4477,6 @@ eog_window_init (EogWindow *window)
 			  window);
 
 	g_signal_connect (priv->ui_settings,
-			  "changed::" EOG_CONF_UI_SCROLL_BUTTONS,
-			  (GCallback) eog_window_scroll_buttons_changed_cb,
-			  window);
-
-	g_signal_connect (priv->ui_settings,
 			  "changed::" EOG_CONF_UI_IMAGE_GALLERY_POSITION,
 			  (GCallback) eog_window_gallery_mode_changed_cb,
 			  window);