[gnome-commander/gcmd-1-2-8] Fixed problem with editing options for favourite apps and devices

[Piotr Eljasiak <epiotr src gnome org>]

commit 88185c0b446fe96c54dae8f6d9687fa22c507e00
Author: Alasdair Craig <ac acraig za net>
Date:   Mon Jun 21 14:45:39 2010 +0200

    Fixed problem with editing options for favourite apps and devices

 NEWS                            |    1 +
 doc/C/gnome-commander.xml       |    3 +++
 src/gnome-cmd-options-dialog.cc |   12 ------------
 3 files changed, 4 insertions(+), 12 deletions(-)
---
diff --git a/NEWS b/NEWS
index 6a5ead4..0c1e3c7 100644
--- a/NEWS
+++ b/NEWS
@@ -6,6 +6,7 @@ Bug fixes:
  * Fixed problem #540438 (no GUI message if meld cannot be executed)
  * Fixed problem #616367 ("File not found" dialog after startup)
  * Fixed problem #620650 (buffer overflow in load_fav_apps())
+ * Fixed problem with editing options for favourite apps and devices
 
 
 ===================================
diff --git a/doc/C/gnome-commander.xml b/doc/C/gnome-commander.xml
index d885124..f5f88c5 100644
--- a/doc/C/gnome-commander.xml
+++ b/doc/C/gnome-commander.xml
@@ -6051,6 +6051,9 @@
                         <listitem>
                             <para>Fixed problem #620650 (buffer overflow in load_fav_apps())</para>
                         </listitem>
+                        <listitem>
+                            <para>Fixed problem with editing options for favourite apps and devices</para>
+                        </listitem>
                     </itemizedlist>
                 </para>
             </entry>
diff --git a/src/gnome-cmd-options-dialog.cc b/src/gnome-cmd-options-dialog.cc
index 6b194c6..6c07cac 100644
--- a/src/gnome-cmd-options-dialog.cc
+++ b/src/gnome-cmd-options-dialog.cc
@@ -1026,10 +1026,7 @@ static void on_add_app_dialog_ok (GtkButton *button, GtkWidget *dialog)
     add_app_to_list (GTK_CLIST (clist), app);
     gtk_widget_destroy (dialog);
 
-    g_free (name);
-    g_free (cmd);
     g_free (icon_path);
-    g_free (pattern_string);
 }
 
 
@@ -1063,10 +1060,7 @@ static void on_edit_app_dialog_ok (GtkButton *button, GtkWidget *dialog)
     update_app_in_list (GTK_CLIST (clist), app);
     gtk_widget_destroy (dialog);
 
-    g_free (name);
-    g_free (cmd);
     g_free (icon_path);
-    g_free (pattern_string);
 }
 
 
@@ -1449,9 +1443,6 @@ static void on_add_device_dialog_ok (GtkButton *button, GtkWidget *dialog)
 
     gnome_cmd_con_list_add_device (gnome_cmd_con_list_get (), dev);
 
-    g_free (alias);
-    g_free (device);
-    g_free (mountp);
     g_free (icon_path);
 }
 
@@ -1472,9 +1463,6 @@ static void on_edit_device_dialog_ok (GtkButton *button, GtkWidget *dialog)
     update_device_in_list (GTK_CLIST (clist), dev, alias, device, mountp, icon_path);
     gtk_widget_destroy (dialog);
 
-    g_free (alias);
-    g_free (device);
-    g_free (mountp);
     g_free (icon_path);
 }