[evolution-data-server] Bug 621740 - Fix double-free of is->literal in cancel_all_jobs()



commit 875ba85ac7e261f33d7aef2ad652f9c871432655
Author: David Woodhouse <David Woodhouse intel com>
Date:   Thu Jun 17 00:09:15 2010 +0100

    Bug 621740 - Fix double-free of is->literal in cancel_all_jobs()
    
    The command which is is->literal is either on the queue or owned somewhere
    else; there's no need for it to be freed in cancel_all_jobs() too.

 camel/providers/imapx/camel-imapx-server.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-server.c b/camel/providers/imapx/camel-imapx-server.c
index 881ddf9..09a3aed 100644
--- a/camel/providers/imapx/camel-imapx-server.c
+++ b/camel/providers/imapx/camel-imapx-server.c
@@ -1670,7 +1670,7 @@ imapx_command_run(CamelIMAPXServer *is, CamelIMAPXCommand *ic)
 		imapx_step(is, ic->ex);
 	} while (ic->status == NULL && !camel_exception_is_set (ic->ex));
 	if (is->literal == ic)
-		is->literal = NULL; 
+		is->literal = NULL;
 
 	QUEUE_LOCK(is);
 	camel_dlist_remove((CamelDListNode *)ic);
@@ -4160,11 +4160,6 @@ imapx_disconnect (CamelIMAPXServer *is)
 		is->select_pending = NULL;
 	}
 
-	if (is->literal) {
-		camel_imapx_command_free (is->literal);
-		is->literal = NULL;
-	}
-
 	if (is->cinfo) {
 		imapx_free_capability(is->cinfo);
 		is->cinfo = NULL;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]