[evolution-data-server] Bug 621740 - Fix double command ->complete() in imapx_command_start_next()
- From: David Woodhouse <dwmw2 src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server] Bug 621740 - Fix double command ->complete() in imapx_command_start_next()
- Date: Thu, 17 Jun 2010 09:51:32 +0000 (UTC)
commit d79d1aa93a6d7c98eae23dbfba1aa0c8f4133982
Author: David Woodhouse <David Woodhouse intel com>
Date: Thu Jun 17 00:06:54 2010 +0100
Bug 621740 - Fix double command ->complete() in imapx_command_start_next()
If imapx_command_start() returns FALSE, it'll already have called the
completion function for the command in question. Don't do it again; it's the
second of the _three_ places that command was getting freed.
camel/providers/imapx/camel-imapx-server.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-server.c b/camel/providers/imapx/camel-imapx-server.c
index 39dac36..881ddf9 100644
--- a/camel/providers/imapx/camel-imapx-server.c
+++ b/camel/providers/imapx/camel-imapx-server.c
@@ -893,11 +893,7 @@ imapx_command_start_next(CamelIMAPXServer *is, CamelException *ex)
c(printf("* queueing job %3d '%s'\n", (gint)ic->pri, ic->name));
pri = ic->pri;
camel_dlist_remove((CamelDListNode *)ic);
- if (!imapx_command_start(is, ic)) {
- QUEUE_UNLOCK (is);
- ic->complete (is, ic);
- QUEUE_LOCK (is);
- }
+ imapx_command_start(is, ic);
count++;
}
ic = nc;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]