[rhythmbox] playbin2: unref bus messages as necessary



commit 21ebc4fab92a79992fedcf2a07580d5590d331c8
Author: Jonathan Matthew <jonathan d14n org>
Date:   Wed Jan 27 21:47:50 2010 +1000

    playbin2: unref bus messages as necessary
    
    Messages retrieved with gst_bus_timed_pop need to be unreffed.  Failing
    to do so leaks references to the source elements, which in turn results
    in memory and file descriptor leaks.

 backends/gstreamer/rb-player-gst.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
---
diff --git a/backends/gstreamer/rb-player-gst.c b/backends/gstreamer/rb-player-gst.c
index 9028130..0bad85a 100644
--- a/backends/gstreamer/rb-player-gst.c
+++ b/backends/gstreamer/rb-player-gst.c
@@ -668,6 +668,8 @@ set_state_and_wait (RBPlayerGst *player, GstState target, GError **error)
 			bus_cb (bus, message, player);
 			break;
 		}
+
+		gst_message_unref (message);
 	}
 
 	if (result == FALSE && error != NULL && *error == NULL) {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]