[gnome-shell] [dnd] revert the change to only allow dropping on reactive actors



commit ed75f0da63583f10716408f4090ee8d56701b2e5
Author: Dan Winship <danw gnome org>
Date:   Wed Jan 20 14:01:37 2010 -0500

    [dnd] revert the change to only allow dropping on reactive actors
    
    Workspace.actor is non-reactive, and there's probably some good reason
    for this. So just have the add workspace button check its own reactivity.

 js/ui/dnd.js      |    2 +-
 js/ui/overview.js |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/dnd.js b/js/ui/dnd.js
index f75bff1..9188cad 100644
--- a/js/ui/dnd.js
+++ b/js/ui/dnd.js
@@ -250,7 +250,7 @@ _Draggable.prototype = {
                                                                   dropX, dropY);
         this._dragActor.show();
         while (target) {
-            if (target.reactive && target._delegate && target._delegate.acceptDrop) {
+            if (target._delegate && target._delegate.acceptDrop) {
                 let [targX, targY] = target.get_transformed_position();
                 if (target._delegate.acceptDrop(this.actor._delegate, this._dragActor,
                                                 (dropX - targX) / target.scale_x,
diff --git a/js/ui/overview.js b/js/ui/overview.js
index 2d41a43..ce6fbfa 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -511,6 +511,6 @@ AddWorkspaceButton.prototype = {
 
     // Draggable target interface
     acceptDrop: function(source, actor, x, y, time) {
-        return this._acceptDropCallback(source, actor, x, y, time);
+        return this.reactive && this._acceptDropCallback(source, actor, x, y, time);
     }
 };



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]