[libgda] Remove compiler warnings
- From: Vivien Malerba <vivien src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgda] Remove compiler warnings
- Date: Tue, 31 Aug 2010 19:41:13 +0000 (UTC)
commit c16347857a3639bfe0b248ff1d4eb7df45a4c5a7
Author: Vivien Malerba <malerba gnome-db org>
Date: Tue Aug 31 21:37:57 2010 +0200
Remove compiler warnings
libgda-report/engine/gda-report-engine.c | 2 +-
libgda-ui/data-entries/common-bin.c | 2 +-
.../data-entries/gdaui-data-cell-renderer-bin.c | 2 +-
.../gdaui-data-cell-renderer-boolean.c | 2 +-
libgda-ui/data-entries/gdaui-entry-date.c | 2 -
libgda-ui/data-entries/gdaui-entry-time.c | 2 -
libgda-ui/data-entries/gdaui-entry-timestamp.c | 2 -
libgda-ui/data-entries/plugins/Makefile.am | 4 -
libgda-ui/data-entries/plugins/common-pict.c | 4 +-
.../plugins/gdaui-data-cell-renderer-cgrid.c | 609 --------------
.../plugins/gdaui-data-cell-renderer-cgrid.h | 78 --
libgda-ui/data-entries/plugins/gdaui-entry-cgrid.c | 872 --------------------
libgda-ui/data-entries/plugins/gdaui-entry-cgrid.h | 69 --
libgda-ui/data-entries/plugins/gdaui-entry-text.c | 6 +-
libgda-ui/data-entries/plugins/libmain.c | 16 -
libgda-ui/gdaui-basic-form.c | 2 +-
libgda-ui/gdaui-combo.c | 2 +-
libgda-ui/gdaui-data-entry.c | 2 +-
libgda-ui/gdaui-data-proxy.c | 4 +-
libgda-ui/gdaui-data-store.c | 2 +-
libgda-ui/gdaui-server-operation.c | 2 +-
libgda-ui/internal/gdaui-provider-auth-editor.c | 2 +-
libgda-ui/internal/gdaui-provider-spec-editor.c | 2 +-
libgda-ui/internal/utility.c | 4 +-
libgda-xslt/sql_backend.c | 8 +-
libgda-xslt/sql_exslt_internal.c | 12 +-
libgda-xslt/sqlexslt.c | 8 +-
libgda/gda-meta-struct-io.c | 4 +
libgda/gda-sql-builder.c | 8 -
libgda/gda-tree-manager.c | 7 -
libgda/gda-util.c | 6 +-
libgda/handlers/gda-handler-time.c | 2 +-
libgda/sql-parser/gda-sql-parser.c | 2 +-
libgda/sqlite/gda-sqlite-meta.c | 2 +
libgda/sqlite/virtual/gda-vprovider-data-model.c | 9 +-
libgda/thread-wrapper/gda-thread-wrapper.c | 7 -
po/POTFILES.in | 2 -
providers/mysql/gda-mysql-recordset.c | 21 -
providers/postgres/gda-postgres-provider.c | 33 -
providers/skel-implementation/capi/gda-capi-meta.c | 4 +-
testing/gda-test-blob.c | 6 +-
testing/html.c | 70 +-
tools/browser/canvas/browser-canvas-fkey.c | 16 -
tools/browser/canvas/browser-canvas-utility.c | 24 -
tools/browser/common/gdaui-data-import.c | 1 +
tools/browser/data-manager/data-console.c | 6 -
.../browser/data-manager/data-favorite-selector.c | 4 +-
tools/browser/query-exec/query-console.c | 10 +-
tools/browser/query-exec/query-favorite-selector.c | 3 -
tools/browser/schema-browser/favorite-selector.c | 4 +-
tools/browser/schema-browser/relations-diagram.c | 6 -
tools/browser/schema-browser/table-columns.c | 6 -
tools/browser/schema-browser/table-info.c | 6 -
tools/browser/schema-browser/table-preferences.c | 6 -
tools/browser/schema-browser/table-relations.c | 6 -
tools/browser/support.c | 7 +
tools/command-exec.c | 2 +-
tools/gda-sql.c | 4 +-
tools/web-server.c | 19 -
59 files changed, 104 insertions(+), 1931 deletions(-)
---
diff --git a/libgda-report/engine/gda-report-engine.c b/libgda-report/engine/gda-report-engine.c
index 0ad4dbc..7200265 100644
--- a/libgda-report/engine/gda-report-engine.c
+++ b/libgda-report/engine/gda-report-engine.c
@@ -953,7 +953,7 @@ rewrite_statement_foreach_func (GdaSqlAnyPart *node, ForeachData *fdata, GError
return TRUE;
GdaHolder *source_param;
- source_param = run_context_find_param (fdata->engine, fdata->context, pspec->name);
+ source_param = run_context_find_param (fdata->engine, fdata->context, BAD_CAST pspec->name);
if (!source_param) {
g_set_error (error, 0, 0,
_("Unknown parameter '%s'"), pspec->name);
diff --git a/libgda-ui/data-entries/common-bin.c b/libgda-ui/data-entries/common-bin.c
index 2df2cd7..af3c0e6 100644
--- a/libgda-ui/data-entries/common-bin.c
+++ b/libgda-ui/data-entries/common-bin.c
@@ -61,7 +61,7 @@ file_load_cb (GtkWidget *button, BinMenu *menu)
GdaBinary *bin;
GValue *nvalue;
bin = g_new0 (GdaBinary, 1);
- bin->data = data;
+ bin->data = (guchar*) data;
bin->binary_length = length;
nvalue = gda_value_new (GDA_TYPE_BINARY);
gda_value_take_binary (nvalue, bin);
diff --git a/libgda-ui/data-entries/gdaui-data-cell-renderer-bin.c b/libgda-ui/data-entries/gdaui-data-cell-renderer-bin.c
index 1c1a514..db353a3 100644
--- a/libgda-ui/data-entries/gdaui-data-cell-renderer-bin.c
+++ b/libgda-ui/data-entries/gdaui-data-cell-renderer-bin.c
@@ -317,7 +317,7 @@ gdaui_data_cell_renderer_bin_set_property (GObject *object,
/**
* gdaui_data_cell_renderer_bin_new:
* @dh: a #GdaDataHandler object
- * @type:
+ * @type: the #GType of the data to be displayed
*
* Creates a new #GdauiDataCellRendererBin. Adjust rendering
* parameters using object properties. Object properties can be set
diff --git a/libgda-ui/data-entries/gdaui-data-cell-renderer-boolean.c b/libgda-ui/data-entries/gdaui-data-cell-renderer-boolean.c
index ad0f03e..62dca29 100644
--- a/libgda-ui/data-entries/gdaui-data-cell-renderer-boolean.c
+++ b/libgda-ui/data-entries/gdaui-data-cell-renderer-boolean.c
@@ -325,7 +325,7 @@ gdaui_data_cell_renderer_boolean_set_property (GObject *object,
/**
* gdaui_data_cell_renderer_boolean_new:
* @dh: a #GdaDataHandler object
- * @type:
+ * @type: the #GType of the data to be displayed
*
* Creates a new #GdauiDataCellRendererBoolean. Adjust rendering
* parameters using object properties. Object properties can be set
diff --git a/libgda-ui/data-entries/gdaui-entry-date.c b/libgda-ui/data-entries/gdaui-entry-date.c
index 36570b6..db53825 100644
--- a/libgda-ui/data-entries/gdaui-entry-date.c
+++ b/libgda-ui/data-entries/gdaui-entry-date.c
@@ -58,8 +58,6 @@ gdaui_entry_date_get_type (void)
static void
gdaui_entry_date_class_init (GdauiEntryDateClass * class)
{
- GObjectClass *object_class = G_OBJECT_CLASS (class);
-
parent_class = g_type_class_peek_parent (class);
}
diff --git a/libgda-ui/data-entries/gdaui-entry-time.c b/libgda-ui/data-entries/gdaui-entry-time.c
index 530b8ff..bf46496 100644
--- a/libgda-ui/data-entries/gdaui-entry-time.c
+++ b/libgda-ui/data-entries/gdaui-entry-time.c
@@ -58,8 +58,6 @@ gdaui_entry_time_get_type (void)
static void
gdaui_entry_time_class_init (GdauiEntryTimeClass * class)
{
- GObjectClass *object_class = G_OBJECT_CLASS (class);
-
parent_class = g_type_class_peek_parent (class);
}
diff --git a/libgda-ui/data-entries/gdaui-entry-timestamp.c b/libgda-ui/data-entries/gdaui-entry-timestamp.c
index 407bc8c..81d02ba 100644
--- a/libgda-ui/data-entries/gdaui-entry-timestamp.c
+++ b/libgda-ui/data-entries/gdaui-entry-timestamp.c
@@ -58,8 +58,6 @@ gdaui_entry_timestamp_get_type (void)
static void
gdaui_entry_timestamp_class_init (GdauiEntryTimestampClass * class)
{
- GObjectClass *object_class = G_OBJECT_CLASS (class);
-
parent_class = g_type_class_peek_parent (class);
}
diff --git a/libgda-ui/data-entries/plugins/Makefile.am b/libgda-ui/data-entries/plugins/Makefile.am
index 57f3177..e1b115c 100644
--- a/libgda-ui/data-entries/plugins/Makefile.am
+++ b/libgda-ui/data-entries/plugins/Makefile.am
@@ -25,11 +25,9 @@ endif
plugins_headers = \
common-pict.h \
- gdaui-data-cell-renderer-cgrid.h \
gdaui-data-cell-renderer-pict.h \
gdaui-entry-filesel.h \
gdaui-entry-cidr.h \
- gdaui-entry-cgrid.h \
gdaui-entry-text.h \
gdaui-entry-pict.h \
$(gcrypt_headers)
@@ -40,11 +38,9 @@ libgda_ui_plugins_la_SOURCES = \
custom-marshal.c \
custom-marshal.h \
libmain.c \
- gdaui-data-cell-renderer-cgrid.c \
gdaui-data-cell-renderer-pict.c \
gdaui-entry-filesel.c \
gdaui-entry-cidr.c \
- gdaui-entry-cgrid.c \
gdaui-entry-text.c \
gdaui-entry-pict.c \
$(gcrypt_sources)
diff --git a/libgda-ui/data-entries/plugins/common-pict.c b/libgda-ui/data-entries/plugins/common-pict.c
index 3420413..23cd2bd 100644
--- a/libgda-ui/data-entries/plugins/common-pict.c
+++ b/libgda-ui/data-entries/plugins/common-pict.c
@@ -590,7 +590,7 @@ common_pict_add_cached_pixbuf (PictOptions *options, const GValue *value, GdkPix
bin = (GdaBinary *) blob;
if (bin) {
if (!bin->data && blob->op)
- gda_blob_op_read_all (blob->op, blob);
+ gda_blob_op_read_all (blob->op, (GdaBlob*) blob);
hash = compute_hash (bin->data, bin->binary_length);
g_hash_table_insert (options->pixbuf_hash, GUINT_TO_POINTER (hash), pixbuf);
g_object_ref (pixbuf);
@@ -626,7 +626,7 @@ common_pict_fetch_cached_pixbuf (PictOptions *options, const GValue *value)
bin = (GdaBinary *) blob;
if (bin) {
if (!bin->data && blob->op)
- gda_blob_op_read_all (blob->op, blob);
+ gda_blob_op_read_all (blob->op, (GdaBlob*) blob);
hash = compute_hash (bin->data, bin->binary_length);
pixbuf = g_hash_table_lookup (options->pixbuf_hash, GUINT_TO_POINTER (hash));
}
diff --git a/libgda-ui/data-entries/plugins/gdaui-entry-text.c b/libgda-ui/data-entries/plugins/gdaui-entry-text.c
index 7904a07..9c57c80 100644
--- a/libgda-ui/data-entries/plugins/gdaui-entry-text.c
+++ b/libgda-ui/data-entries/plugins/gdaui-entry-text.c
@@ -323,8 +323,8 @@ real_set_value (GdauiEntryWrapper *mgwrap, const GValue *value)
bin = (GdaBinary *) blob;
if (blob->op &&
(bin->binary_length != gda_blob_op_get_length (blob->op)))
- gda_blob_op_read_all (blob->op, blob);
- if (g_utf8_validate (bin->data, bin->binary_length, NULL)) {
+ gda_blob_op_read_all (blob->op, (GdaBlob*) blob);
+ if (g_utf8_validate ((gchar*) bin->data, bin->binary_length, NULL)) {
gtk_text_buffer_set_text (mgtxt->priv->buffer, (gchar*) bin->data,
bin->binary_length);
done = TRUE;
@@ -333,7 +333,7 @@ real_set_value (GdauiEntryWrapper *mgwrap, const GValue *value)
else if (G_VALUE_TYPE (value) == GDA_TYPE_BINARY) {
const GdaBinary *bin;
bin = gda_value_get_binary (value);
- if (g_utf8_validate (bin->data, bin->binary_length, NULL)) {
+ if (g_utf8_validate ((gchar*) bin->data, bin->binary_length, NULL)) {
gtk_text_buffer_set_text (mgtxt->priv->buffer, (gchar*) bin->data,
bin->binary_length);
done = TRUE;
diff --git a/libgda-ui/data-entries/plugins/libmain.c b/libgda-ui/data-entries/plugins/libmain.c
index c8d009d..8b83ff4 100644
--- a/libgda-ui/data-entries/plugins/libmain.c
+++ b/libgda-ui/data-entries/plugins/libmain.c
@@ -31,8 +31,6 @@
#include "gdaui-entry-text.h"
#include "gdaui-entry-pict.h"
#include "gdaui-data-cell-renderer-pict.h"
-#include "gdaui-entry-cgrid.h"
-#include "gdaui-data-cell-renderer-cgrid.h"
#ifdef HAVE_LIBGCRYPT
#include "gdaui-entry-password.h"
@@ -56,8 +54,6 @@ static GdauiDataEntry *plugin_entry_cidr_create_func (GdaDataHandler *handler, G
static GdauiDataEntry *plugin_entry_text_create_func (GdaDataHandler *handler, GType type, const gchar *options);
static GdauiDataEntry *plugin_entry_pict_create_func (GdaDataHandler *handler, GType type, const gchar *options);
static GtkCellRenderer *plugin_cell_renderer_pict_create_func (GdaDataHandler *handler, GType type, const gchar *options);
-static GdauiDataEntry *plugin_entry_cgrid_create_func (GdaDataHandler *handler, GType type, const gchar *options);
-static GtkCellRenderer *plugin_cell_renderer_cgrid_create_func (GdaDataHandler *handler, GType type, const gchar *options);
#ifdef HAVE_LIBGCRYPT
static GdauiDataEntry *plugin_entry_password_create_func (GdaDataHandler *handler, GType type, const gchar *options);
@@ -299,18 +295,6 @@ plugin_cell_renderer_pict_create_func (GdaDataHandler *handler, GType type, cons
return gdaui_data_cell_renderer_pict_new (handler, type, options);
}
-static GdauiDataEntry *
-plugin_entry_cgrid_create_func (GdaDataHandler *handler, GType type, const gchar *options)
-{
- return (GdauiDataEntry *) gdaui_entry_cgrid_new (handler, type, options);
-}
-
-static GtkCellRenderer *
-plugin_cell_renderer_cgrid_create_func (GdaDataHandler *handler, GType type, const gchar *options)
-{
- return (GtkCellRenderer *) gdaui_data_cell_renderer_cgrid_new (handler, type, options);
-}
-
#ifdef HAVE_LIBGCRYPT
static GdauiDataEntry *
plugin_entry_password_create_func (GdaDataHandler *handler, GType type, const gchar *options)
diff --git a/libgda-ui/gdaui-basic-form.c b/libgda-ui/gdaui-basic-form.c
index b6a7632..64055e1 100644
--- a/libgda-ui/gdaui-basic-form.c
+++ b/libgda-ui/gdaui-basic-form.c
@@ -1665,7 +1665,7 @@ gdaui_basic_form_reset (GdauiBasicForm *form)
* gdaui_basic_form_entry_set_visible
* @form: a #GdauiBasicForm widget
* @param: a #GdaHolder object
- * @show:
+ * @show: set to %TRUE to show the data entry, and to %FALSE to hide it
*
* Shows or hides the #GdauiDataEntry in @form which corresponds to the
* @param parameter
diff --git a/libgda-ui/gdaui-combo.c b/libgda-ui/gdaui-combo.c
index ee13485..b3549b9 100644
--- a/libgda-ui/gdaui-combo.c
+++ b/libgda-ui/gdaui-combo.c
@@ -627,7 +627,7 @@ _gdaui_combo_get_selected_ext (GdauiCombo *combo, gint n_cols, gint *cols_index)
/**
* gdaui_combo_add_null
* @combo: a #GdauiCombo widget
- * @add_undef_choice:
+ * @add_null: set to %TRUE to add a NULL value to the combo box
*
* Tells if @combo should add a special entry representing an "undefined choice", as a %NULL entry. The default is
* that only the available choices in @combo's model are presented.
diff --git a/libgda-ui/gdaui-data-entry.c b/libgda-ui/gdaui-data-entry.c
index bb5cc41..7c00024 100644
--- a/libgda-ui/gdaui-data-entry.c
+++ b/libgda-ui/gdaui-data-entry.c
@@ -132,7 +132,7 @@ gdaui_data_entry_iface_init (gpointer g_class)
/**
* gdaui_data_entry_set_value_type
* @de: a #GtkWidget object which implements the #GdauiDataEntry interface
- * @type:
+ * @type: the #GType of the data to be displayed
*
* Sets the type of value the GdauiDataEntry will handle. The type must be compatible with what
* the widget can handle.
diff --git a/libgda-ui/gdaui-data-proxy.c b/libgda-ui/gdaui-data-proxy.c
index aa44bea..6c4d2f9 100644
--- a/libgda-ui/gdaui-data-proxy.c
+++ b/libgda-ui/gdaui-data-proxy.c
@@ -104,7 +104,7 @@ gdaui_data_proxy_get_proxy (GdauiDataProxy *iface)
* gdaui_data_proxy_column_set_editable
* @iface: an object which implements the #GdauiDataProxy interface
* @column: column number of the data
- * @editable:
+ * @editable: set to %TRUE to make the column editable
*
* Sets if the data entry in the @iface widget at @column (in the data model @iface operates on)
* can be edited or not.
@@ -250,7 +250,7 @@ gdaui_data_proxy_perform_action (GdauiDataProxy *iface, GdauiAction action)
/**
* gdaui_data_proxy_set_write_mode
* @iface: an object which implements the #GdauiDataProxy interface
- * @mode:
+ * @mode: the requested #GdauiDataProxyWriteMode mode
*
* Specifies the way the modifications stored in the #GdaDataProxy used internally by @iface are written back to
* the #GdaDataModel which holds the data displayed in @iface.
diff --git a/libgda-ui/gdaui-data-store.c b/libgda-ui/gdaui-data-store.c
index 4dd6934..5c8cd94 100644
--- a/libgda-ui/gdaui-data-store.c
+++ b/libgda-ui/gdaui-data-store.c
@@ -348,7 +348,7 @@ gdaui_data_store_new (GdaDataModel *model)
* gdaui_data_store_set_value
* @store: a #GdauiDataStore object
* @iter: the considered row
- * @col:
+ * @col: the data model column
* @value: the value to store (gets copied)
*
* Stores a value in the @store data model.
diff --git a/libgda-ui/gdaui-server-operation.c b/libgda-ui/gdaui-server-operation.c
index e27faa7..2cbf625 100644
--- a/libgda-ui/gdaui-server-operation.c
+++ b/libgda-ui/gdaui-server-operation.c
@@ -1267,7 +1267,7 @@ create_table_proxy_row_inserted_cb (GdaDataProxy *proxy, gint row, GdauiServerOp
GdaHolder *holder;
GdaServerProvider *prov;
GdaConnection *cnc;
- gchar *type = NULL;
+ const gchar *type = NULL;
iter = gda_data_model_create_iter (GDA_DATA_MODEL (proxy));
gda_data_model_iter_move_to_row (iter, row);
diff --git a/libgda-ui/internal/gdaui-provider-auth-editor.c b/libgda-ui/internal/gdaui-provider-auth-editor.c
index ef4262f..3dd414b 100644
--- a/libgda-ui/internal/gdaui-provider-auth-editor.c
+++ b/libgda-ui/internal/gdaui-provider-auth-editor.c
@@ -206,7 +206,7 @@ _gdaui_provider_auth_editor_get_type (void)
*
* Creates a new #GdauiProviderAuthEditor widget
*
- * Returns:
+ * Returns: a new widget
*/
GtkWidget *
_gdaui_provider_auth_editor_new (const gchar *provider)
diff --git a/libgda-ui/internal/gdaui-provider-spec-editor.c b/libgda-ui/internal/gdaui-provider-spec-editor.c
index 4738010..3960c13 100644
--- a/libgda-ui/internal/gdaui-provider-spec-editor.c
+++ b/libgda-ui/internal/gdaui-provider-spec-editor.c
@@ -482,7 +482,7 @@ _gdaui_provider_spec_editor_get_specs (GdauiProviderSpecEditor *spec)
/**
* _gdaui_provider_spec_editor_set_specs
* @spec: a #GdauiProviderSpecEditor widget
- * @specs_string:
+ * @specs_string: the connection string
*
* Sets the connection string to be displayed in the widget
*/
diff --git a/libgda-ui/internal/utility.c b/libgda-ui/internal/utility.c
index 37d7a43..099f664 100644
--- a/libgda-ui/internal/utility.c
+++ b/libgda-ui/internal/utility.c
@@ -456,7 +456,7 @@ create_data_error_dialog (GdauiDataProxy *form, gboolean with_question, gboolean
/**
* _gdaui_utility_display_error_with_keep_or_discard_choice
- * @form:
+ * @form: a #GdauiDataProxy
* @filled_error: a #GError containing the error to display
*
* Displays a dialog showing @filled_error's message and asks the user to either keep the data which
@@ -485,7 +485,7 @@ _gdaui_utility_display_error_with_keep_or_discard_choice (GdauiDataProxy *form,
/**
* _gdaui_utility_display_error
- * @form:
+ * @form: a #GdauiDataProxy
* @filled_error: a #GError containing the error to display
*
* Displays a dialog showing @filled_error's message and asks the user to either keep the data which
diff --git a/libgda-xslt/sql_backend.c b/libgda-xslt/sql_backend.c
index 41319a2..08ff6c7 100644
--- a/libgda-xslt/sql_backend.c
+++ b/libgda-xslt/sql_backend.c
@@ -191,7 +191,7 @@ gda_xslt_bk_fun_getnodeset (xmlChar * set, GdaXsltExCont * exec,
#ifdef GDA_DEBUG_NO
printf ("running function:gda_xslt_bk_fun_getnodeset\n");
#endif
- res = get_resultset_nodeset (pdata, set, &nodeset, &(exec->error));
+ res = get_resultset_nodeset (pdata, (gchar*) set, &nodeset, &(exec->error));
if (res < 0 || nodeset == NULL) {
xsltGenericError (xsltGenericErrorContext,
"gda_xslt_bk_fun_getnodeset error\n");
@@ -325,7 +325,7 @@ get_resultset_col_value (GdaXsltIntCont * pdata, const char *resultset_name,
return -1;
}
gchar *gvalue_string;
- gvalue_string = value_to_xmlchar (db_value);
+ gvalue_string = (gchar*) value_to_xmlchar (db_value);
if (gvalue_string == NULL) {
#ifdef GDA_DEBUG_NO
g_print ("faild to stringify gvalue");
@@ -510,7 +510,7 @@ gda_xslt_bk_internal_query (GdaXsltExCont * exec, GdaXsltIntCont * pdata,
return -1;
}
- look_predefined_query_by_name (exec, query_name, &(query));
+ look_predefined_query_by_name (exec, (gchar*) query_name, &(query));
if (!query) {
/* the query is not predefined */
/* get the xml text node with the sql */
@@ -526,7 +526,7 @@ gda_xslt_bk_internal_query (GdaXsltExCont * exec, GdaXsltIntCont * pdata,
/* create the query */
GdaSqlParser *parser;
parser = gda_connection_create_parser (exec->cnc);
- query = gda_sql_parser_parse_string (parser, XML_GET_CONTENT (sqltxt_node), NULL, &(exec->error));
+ query = gda_sql_parser_parse_string (parser, (gchar*) XML_GET_CONTENT (sqltxt_node), NULL, &(exec->error));
g_object_unref (parser);
if (!query) {
#ifdef GDA_DEBUG_NO
diff --git a/libgda-xslt/sql_exslt_internal.c b/libgda-xslt/sql_exslt_internal.c
index e0be9d7..9cc796e 100644
--- a/libgda-xslt/sql_exslt_internal.c
+++ b/libgda-xslt/sql_exslt_internal.c
@@ -53,7 +53,7 @@ gda_xslt_extension_init (xsltTransformContextPtr ctxt, const xmlChar * URI)
#ifdef GDA_DEBUG_NO
g_print ("gda_xslt_extension_init");
#endif
- if (!URI || strcmp (URI, GDA_XSLT_EXTENSION_URI)) {
+ if (!URI || strcmp ((gchar*) URI, GDA_XSLT_EXTENSION_URI)) {
#ifdef GDA_DEBUG_NO
g_print ("called for another URI, exit");
#endif
@@ -136,7 +136,7 @@ gda_xslt_getnodeset_function (xmlXPathParserContextPtr ctxt, int nargs)
}
execc = (GdaXsltExCont *) tctxt->_private;
data = (GdaXsltIntCont *) xsltGetExtData (tctxt,
- GDA_XSLT_EXTENSION_URI);
+ BAD_CAST GDA_XSLT_EXTENSION_URI);
if (data == NULL) {
xsltGenericError (xsltGenericErrorContext,
"sqlxslt: failed to get module data\n");
@@ -189,7 +189,7 @@ gda_xslt_checkif_function (xmlXPathParserContextPtr ctxt, int nargs)
}
execc = (GdaXsltExCont *) tctxt->_private;
data = (GdaXsltIntCont *) xsltGetExtData (tctxt,
- GDA_XSLT_EXTENSION_URI);
+ BAD_CAST GDA_XSLT_EXTENSION_URI);
if (data == NULL || execc == NULL) {
xsltGenericError (xsltGenericErrorContext,
"gda_xslt_checkif_function: failed to get module internal data\n");
@@ -255,7 +255,7 @@ gda_xslt_getvalue_function (xmlXPathParserContextPtr ctxt, int nargs)
execc = (GdaXsltExCont *) tctxt->_private;
data = (GdaXsltIntCont *) xsltGetExtData (tctxt,
- GDA_XSLT_EXTENSION_URI);
+ BAD_CAST GDA_XSLT_EXTENSION_URI);
if (data == NULL || execc == NULL) {
xsltGenericError (xsltGenericErrorContext,
"gda_xslt_getvalue_function: failed to get module internal data\n");
@@ -322,7 +322,7 @@ gda_xslt_getxmlvalue_function (xmlXPathParserContextPtr ctxt, int nargs)
execc = (GdaXsltExCont *) tctxt->_private;
data = (GdaXsltIntCont *) xsltGetExtData (tctxt,
- GDA_XSLT_EXTENSION_URI);
+ BAD_CAST GDA_XSLT_EXTENSION_URI);
if (data == NULL || execc == NULL) {
xsltGenericError (xsltGenericErrorContext,
"gda_xslt_getxmlvalue_function: failed to get module internal data\n");
@@ -387,7 +387,7 @@ gda_xslt_section_element (xsltTransformContextPtr tctxt,
execc = (GdaXsltExCont *) tctxt->_private;
data = (GdaXsltIntCont *) xsltGetExtData (tctxt,
- GDA_XSLT_EXTENSION_URI);
+ BAD_CAST GDA_XSLT_EXTENSION_URI);
if (data == NULL || execc == NULL) {
xsltGenericError (xsltGenericErrorContext,
"gda_xslt_section_element: failed to get module internal data\n");
diff --git a/libgda-xslt/sqlexslt.c b/libgda-xslt/sqlexslt.c
index 3e18cdd..0c6cca8 100644
--- a/libgda-xslt/sqlexslt.c
+++ b/libgda-xslt/sqlexslt.c
@@ -49,7 +49,7 @@ gda_xslt_register (void)
int init_res;
init = 1;
init_res =
- xsltRegisterExtModule (GDA_XSLT_EXTENSION_URI,
+ xsltRegisterExtModule (BAD_CAST GDA_XSLT_EXTENSION_URI,
gda_xslt_extension_init,
gda_xslt_extension_shutdown);
if (init_res != 0) {
@@ -74,13 +74,15 @@ gda_xslt_set_execution_context (xsltTransformContextPtr tcxt,
/**
* gda_xslt_create_context_simple
+ * @cnc: a #GdaConnection
+ * @error: a place to store errors, or %NULL
*
- * create a gda-xslt context with the Gdaconnection and not predefined queries
+ * create a gda-xslt context with the Gdaconnection and not predefined queries
*
* Returns:
*/
GdaXsltExCont *
-gda_xslt_create_context_simple (GdaConnection * cnc, GError ** error)
+gda_xslt_create_context_simple (GdaConnection *cnc, GError **error)
{
GdaXsltExCont *local = NULL;
diff --git a/libgda/gda-meta-struct-io.c b/libgda/gda-meta-struct-io.c
index 400067b..d966db8 100644
--- a/libgda/gda-meta-struct-io.c
+++ b/libgda/gda-meta-struct-io.c
@@ -31,8 +31,10 @@
static GdaMetaDbObject *create_table_object (GdaMetaStruct *mstruct, const GValue *catalog, const gchar *quoted_catalog,
const GValue *schema, const gchar *quoted_schema, xmlNodePtr node, GError **error);
+/*
static GdaMetaDbObject *create_view_object (GdaMetaStruct *mstruct, const GValue *catalog, const gchar *quoted_catalog,
const GValue *schema, const gchar *quoted_schema, xmlNodePtr node, GError **error);
+*/
@@ -394,6 +396,7 @@ create_table_object (GdaMetaStruct *mstruct, const GValue *catalog, const gchar
return NULL;
}
+/*
static GdaMetaDbObject *
create_view_object (GdaMetaStruct *mstruct, const GValue *catalog, const gchar *quoted_catalog,
const GValue *schema, const gchar *quoted_schema, xmlNodePtr node, GError **error)
@@ -401,4 +404,5 @@ create_view_object (GdaMetaStruct *mstruct, const GValue *catalog, const gchar *
TO_IMPLEMENT;
return NULL;
}
+*/
diff --git a/libgda/gda-sql-builder.c b/libgda/gda-sql-builder.c
index 8806bfb..a1fe8c5 100644
--- a/libgda/gda-sql-builder.c
+++ b/libgda/gda-sql-builder.c
@@ -61,14 +61,6 @@ struct _GdaSqlBuilderPrivate {
/* get a pointer to the parents to be able to call their destructor */
static GObjectClass *parent_class = NULL;
-/* signals */
-enum {
- DUMMY,
- LAST_SIGNAL
-};
-
-static gint gda_sql_builder_signals[LAST_SIGNAL] = { 0 };
-
/* properties */
enum {
PROP_0,
diff --git a/libgda/gda-tree-manager.c b/libgda/gda-tree-manager.c
index 57194ee..f10c32c 100644
--- a/libgda/gda-tree-manager.c
+++ b/libgda/gda-tree-manager.c
@@ -52,13 +52,6 @@ static void gda_tree_manager_get_property (GObject *object,
GValue *value,
GParamSpec *pspec);
-enum {
- DUMMY,
- LAST_SIGNAL
-};
-
-static gint gda_tree_manager_signals[LAST_SIGNAL] = { 0 };
-
/* properties */
enum {
PROP_0,
diff --git a/libgda/gda-util.c b/libgda/gda-util.c
index 6687a01..2e1e970 100644
--- a/libgda/gda-util.c
+++ b/libgda/gda-util.c
@@ -326,7 +326,7 @@ gda_utility_check_data_model (GdaDataModel *model, gint nbcols, ...)
* @nb_cols: the number of columns in @cols
* @rows: an array containing which rows of @model will be exported, or %NULL for all rows
* @nb_rows: the number of rows in @rows
- * @use_col_ids:
+ * @use_col_ids: set to %TRUE to add column ID information
*
* Dump the data in a #GdaDataModel into a xmlNodePtr (as used in libxml).
*
@@ -512,7 +512,7 @@ gda_utility_data_model_find_column_description (GdaDataSelect *model, const gcha
/**
* gda_utility_holder_load_attributes
- * @holder:
+ * @holder: a #GdaHolder
* @node: an xmlNodePtr with a <parameter> tag
* @sources: a list of #GdaDataModel
* @error: a place to store errors, or %NULL
@@ -686,7 +686,7 @@ gda_utility_holder_load_attributes (GdaHolder *holder, xmlNodePtr node, GSList *
#define GDA_PARAM_ENCODE_TOKEN "__gda"
/**
* gda_text_to_alphanum
- * @text:
+ * @text: the text to convert
*
* The "encoding" consists in replacing non
* alphanumeric character with the string "__gdaXX" where XX is the hex. representation
diff --git a/libgda/handlers/gda-handler-time.c b/libgda/handlers/gda-handler-time.c
index 6dc3bbd..a164395 100644
--- a/libgda/handlers/gda-handler-time.c
+++ b/libgda/handlers/gda-handler-time.c
@@ -312,7 +312,7 @@ handler_compute_locale (GdaHandlerTime *hdl)
/* computations */
if (!error) {
-#ifdef GDA_DEBUG
+#ifdef GDA_DEBUG_NO
gchar *strings[3];
#endif
gint i;
diff --git a/libgda/sql-parser/gda-sql-parser.c b/libgda/sql-parser/gda-sql-parser.c
index b593f8e..49577bc 100644
--- a/libgda/sql-parser/gda-sql-parser.c
+++ b/libgda/sql-parser/gda-sql-parser.c
@@ -1378,7 +1378,7 @@ getToken (GdaSqlParser *parser)
retval = token_as_string (parser->priv->context->next_token_start, consumed_chars);
/* remove comments from returned string */
gchar *tmp, *ptr;
- tmp = g_value_get_string (retval);
+ tmp = (gchar*) g_value_get_string (retval);
for (ptr = tmp; *ptr; ptr++) {
if (((ptr == tmp) || (*(ptr-1) == '\n')) && (*ptr == '-') && (ptr[1] == '-')) {
/* we have a comment */
diff --git a/libgda/sqlite/gda-sqlite-meta.c b/libgda/sqlite/gda-sqlite-meta.c
index 8fe13fa..3925ab5 100644
--- a/libgda/sqlite/gda-sqlite-meta.c
+++ b/libgda/sqlite/gda-sqlite-meta.c
@@ -2109,6 +2109,7 @@ _gda_sqlite_meta__routines (GdaServerProvider *prov, GdaConnection *cnc,
return _gda_sqlite_meta_routines (prov, cnc, store, context, error, NULL, NULL, NULL);
}
+#ifndef HAVE_SQLITE
static gboolean
fill_routines (GdaDataModel *mod_model,
const GValue *rname, const GValue *is_agg, const GValue *rnargs, const GValue *sname, GError **error)
@@ -2148,6 +2149,7 @@ fill_routines (GdaDataModel *mod_model,
return retval;
}
+#endif
gboolean
_gda_sqlite_meta_routines (GdaServerProvider *prov, GdaConnection *cnc,
diff --git a/libgda/sqlite/virtual/gda-vprovider-data-model.c b/libgda/sqlite/virtual/gda-vprovider-data-model.c
index 2c20a4e..972041e 100644
--- a/libgda/sqlite/virtual/gda-vprovider-data-model.c
+++ b/libgda/sqlite/virtual/gda-vprovider-data-model.c
@@ -564,7 +564,6 @@ virtual_table_manage_real_data_model (VirtualTable *vtable)
}
else {
/* no random access => use a wrapper */
- GdaDataModel *wrapper;
vtable->wrapper = gda_data_access_wrapper_new (vtable->td->real_model);
}
}
@@ -617,7 +616,7 @@ static int
virtualNext (sqlite3_vtab_cursor *cur)
{
VirtualCursor *cursor = (VirtualCursor*) cur;
- VirtualTable *vtable = (VirtualTable*) cur->pVtab;
+ /*VirtualTable *vtable = (VirtualTable*) cur->pVtab;*/
TRACE ();
@@ -851,17 +850,13 @@ virtualSync (sqlite3_vtab *tab)
static int
virtualCommit (sqlite3_vtab *tab)
{
- VirtualTable *vtable = (VirtualTable *) tab;
-
TRACE ();
return SQLITE_OK;
}
static int
virtualRollback (sqlite3_vtab *tab)
-{
- VirtualTable *vtable = (VirtualTable *) tab;
-
+{
TRACE ();
return SQLITE_OK;
}
diff --git a/libgda/thread-wrapper/gda-thread-wrapper.c b/libgda/thread-wrapper/gda-thread-wrapper.c
index beaa767..f2514d5 100644
--- a/libgda/thread-wrapper/gda-thread-wrapper.c
+++ b/libgda/thread-wrapper/gda-thread-wrapper.c
@@ -249,13 +249,6 @@ static void gda_thread_wrapper_get_property (GObject *object,
GValue *value,
GParamSpec *pspec);
-enum {
- DUMMY,
- LAST_SIGNAL
-};
-
-static gint gda_thread_wrapper_signals[LAST_SIGNAL] = { 0 };
-
/* properties */
enum {
PROP_0
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 6e2bd87..54a4c70 100755
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -96,10 +96,8 @@ libgda-ui/data-entries/gdaui-formatted-entry.c
libgda-ui/data-entries/gdaui-numeric-entry.c
libgda-ui/data-entries/plugins/common-pict.c
libgda-ui/data-entries/plugins/gda-sql.lang
-libgda-ui/data-entries/plugins/gdaui-data-cell-renderer-cgrid.c
libgda-ui/data-entries/plugins/gdaui-data-cell-renderer-password.c
libgda-ui/data-entries/plugins/gdaui-data-cell-renderer-pict.c
-libgda-ui/data-entries/plugins/gdaui-entry-cgrid.c
libgda-ui/data-entries/plugins/gdaui-entry-cidr.c
libgda-ui/data-entries/plugins/gdaui-entry-filesel-spec.xml.in
libgda-ui/data-entries/plugins/gdaui-entry-filesel.c
diff --git a/providers/mysql/gda-mysql-recordset.c b/providers/mysql/gda-mysql-recordset.c
index 48bd3fb..6fbc04d 100644
--- a/providers/mysql/gda-mysql-recordset.c
+++ b/providers/mysql/gda-mysql-recordset.c
@@ -907,27 +907,6 @@ gda_mysql_recordset_fetch_random (GdaDataSelect *model,
}
/*
- * Create and "give" filled #GdaRow object for all the rows in the model
- */
-static gboolean
-gda_mysql_recordset_store_all (GdaDataSelect *model,
- GError **error)
-{
- GdaMysqlRecordset *imodel;
- gint i;
-
- imodel = GDA_MYSQL_RECORDSET (model);
-
- /* default implementation */
- for (i = 0; i < model->advertized_nrows; i++) {
- GdaRow *row;
- if (! gda_mysql_recordset_fetch_random (model, &row, i, error))
- return FALSE;
- }
- return TRUE;
-}
-
-/*
* Create a new filled #GdaRow object for the next cursor row, and put it into *row.
*
* WARNING: @row will NOT be NULL, but *row may or may not be NULL:
diff --git a/providers/postgres/gda-postgres-provider.c b/providers/postgres/gda-postgres-provider.c
index 35c1c30..019342a 100644
--- a/providers/postgres/gda-postgres-provider.c
+++ b/providers/postgres/gda-postgres-provider.c
@@ -353,39 +353,6 @@ gda_postgres_provider_get_version (GdaServerProvider *provider)
return PACKAGE_VERSION;
}
-/* get the float version of a Postgres version which looks like:
- * PostgreSQL 7.2.2 on i686-pc-linux-gnu, compiled by GCC 2.96 => returns 7.22
- * PostgreSQL 7.3 on i686-pc-linux-gnu, compiled by GCC 2.95.3 => returns 7.3
- * WARNING: no serious test is made on the validity of the string
- */
-static gfloat
-get_pg_version_float (const gchar *str)
-{
- gfloat retval = 0.;
- const gchar *ptr;
- gfloat div = 1;
-
- if (!str)
- return retval;
-
- /* go on the first digit of version number */
- ptr = str;
- while (*ptr != ' ')
- ptr++;
- ptr++;
-
- /* elaborate the real version number */
- while (*ptr != ' ') {
- if (*ptr != '.') {
- retval += (*ptr - '0')/div;
- div *= 10;
- }
- ptr++;
- }
-
- return retval;
-}
-
static void
pq_notice_processor (GdaConnection *cnc, const char *message)
{
diff --git a/providers/skel-implementation/capi/gda-capi-meta.c b/providers/skel-implementation/capi/gda-capi-meta.c
index 5757754..b39c937 100644
--- a/providers/skel-implementation/capi/gda-capi-meta.c
+++ b/providers/skel-implementation/capi/gda-capi-meta.c
@@ -98,7 +98,7 @@ gboolean
_gda_capi_meta__info (GdaServerProvider *prov, GdaConnection *cnc,
GdaMetaStore *store, GdaMetaContext *context, GError **error)
{
- GdaDataModel *model;
+ GdaDataModel *model = NULL;
gboolean retval;
TO_IMPLEMENT;
@@ -137,7 +137,7 @@ _gda_capi_meta_udt (GdaServerProvider *prov, GdaConnection *cnc,
GdaMetaStore *store, GdaMetaContext *context, GError **error,
const GValue *udt_catalog, const GValue *udt_schema)
{
- GdaDataModel *model;
+ GdaDataModel *model = NULL;
gboolean retval = TRUE;
/* set internal holder's values from the arguments */
diff --git a/testing/gda-test-blob.c b/testing/gda-test-blob.c
index 6c4f50e..ca6bda6 100644
--- a/testing/gda-test-blob.c
+++ b/testing/gda-test-blob.c
@@ -226,7 +226,7 @@ insert_blob (GdaConnection *cnc, gint id, const gchar *data, glong binary_length
/* blob data */
param = gda_set_get_holder (plist, "theblob");
- value = gda_value_new_blob (data, binary_length);
+ value = gda_value_new_blob ((guchar*) data, binary_length);
if (! gda_holder_set_value (param, value, error))
return FALSE;
gda_value_free (value);
@@ -273,7 +273,7 @@ update_blob (GdaConnection *cnc, gint id, const gchar *data, glong binary_length
/* blob data */
param = gda_set_get_holder (plist, "theblob");
- value = gda_value_new_blob (data, binary_length);
+ value = gda_value_new_blob ((guchar*) data, binary_length);
if (! gda_holder_set_value (param, value, error))
return FALSE;
gda_value_free (value);
@@ -310,7 +310,7 @@ update_multiple_blobs (GdaConnection *cnc, const gchar *data, glong binary_lengt
/* blob data */
param = gda_set_get_holder (plist, "theblob");
- value = gda_value_new_blob (data, binary_length);
+ value = gda_value_new_blob ((guchar*) data, binary_length);
if (! gda_holder_set_value (param, value, error))
return FALSE;
gda_value_free (value);
diff --git a/testing/html.c b/testing/html.c
index 052ff54..61fa582 100644
--- a/testing/html.c
+++ b/testing/html.c
@@ -19,20 +19,20 @@ html_file_new (HtmlConfig *config, const gchar *name, const gchar *title)
file = g_new0 (HtmlFile, 1);
file->name = g_strdup (name);
- file->doc = xmlNewDoc ("1.0");
- topnode = xmlNewDocNode (file->doc, NULL, "html", NULL);
+ file->doc = xmlNewDoc (BAD_CAST "1.0");
+ topnode = xmlNewDocNode (file->doc, NULL, BAD_CAST "html", NULL);
xmlDocSetRootElement (file->doc, topnode);
/* head */
- head = xmlNewChild (topnode, NULL, "head", NULL);
+ head = xmlNewChild (topnode, NULL, BAD_CAST "head", NULL);
- node = xmlNewChild (head, NULL, "meta", NULL);
- xmlSetProp(node, "content", (xmlChar*)"charset=UTF-8");
- xmlSetProp(node, "http-equiv", (xmlChar*)"content-type");
+ node = xmlNewChild (head, NULL, BAD_CAST "meta", NULL);
+ xmlSetProp(node, BAD_CAST "content", BAD_CAST "charset=UTF-8");
+ xmlSetProp(node, BAD_CAST "http-equiv", BAD_CAST "content-type");
- node = xmlNewChild (head, NULL, "title", title);
- node = xmlNewChild (head, NULL, "style",
-"body { "
+ node = xmlNewChild (head, NULL, BAD_CAST "title", BAD_CAST title);
+ node = xmlNewChild (head, NULL, BAD_CAST "style",
+BAD_CAST "body { "
" margin: 0px; padding: 0px; border:0px; "
" font: 8pt/16pt georgia; "
" color: #555753; "
@@ -106,12 +106,12 @@ html_file_new (HtmlConfig *config, const gchar *name, const gchar *title)
);
/* body */
- node = xmlNewChild (topnode, NULL, "body", NULL);
+ node = xmlNewChild (topnode, NULL, BAD_CAST "body", NULL);
file->body = node;
/* title */
- node = xmlNewChild (file->body, NULL, "h1", title);
- xmlSetProp(node, "class", (xmlChar*)"title");
+ node = xmlNewChild (file->body, NULL, BAD_CAST "h1", BAD_CAST title);
+ xmlSetProp(node, BAD_CAST "class", BAD_CAST "title");
#ifdef NO
/* toc */
@@ -181,7 +181,7 @@ real_html_add_link_to_node (xmlNodePtr node, const gchar *text, const gchar *lin
href = xmlNewNode (NULL, (xmlChar*)"a");
tmp = g_strdup_printf (" [%s] ", text);
- xmlNodeSetContent (href, tmp);
+ xmlNodeSetContent (href, BAD_CAST tmp);
g_free (tmp);
if (node->children) {
xmlNodePtr sibl;
@@ -198,11 +198,11 @@ real_html_add_link_to_node (xmlNodePtr node, const gchar *text, const gchar *lin
xmlAddChild (node, href);
if (*link_to == '/') {
tmp = g_strdup_printf ("#%s", link_to);
- xmlSetProp(href, (xmlChar*)"href", tmp);
+ xmlSetProp(href, BAD_CAST "href", BAD_CAST tmp);
g_free (tmp);
}
else
- xmlSetProp(href, (xmlChar*)"href", link_to);
+ xmlSetProp(href, BAD_CAST "href", BAD_CAST link_to);
}
void
@@ -224,7 +224,7 @@ html_add_to_toc (HtmlConfig *config, HtmlFile *file, const gchar *text, const gc
{
xmlNodePtr li;
- li = xmlNewChild (file->toc, NULL, "li", NULL);
+ li = xmlNewChild (file->toc, NULL, BAD_CAST "li", NULL);
real_html_add_link_to_node (li, text, link_to);
}
@@ -234,11 +234,11 @@ html_add_header (HtmlConfig *config, HtmlFile *file, const gchar *text)
xmlNodePtr hnode, ntmp;
gchar *tmp;
- hnode = xmlNewChild (file->body, NULL, "h2", text);
+ hnode = xmlNewChild (file->body, NULL, BAD_CAST "h2", BAD_CAST text);
tmp = g_strdup_printf ("/a/%d", counter++);
html_add_to_toc (config, file, text, tmp);
- ntmp = xmlNewChild (hnode, NULL, "a", "");
- xmlSetProp(ntmp, (xmlChar*)"name", tmp);
+ ntmp = xmlNewChild (hnode, NULL, BAD_CAST "a", BAD_CAST "");
+ xmlSetProp(ntmp, BAD_CAST "name", BAD_CAST tmp);
g_free (tmp);
return hnode;
@@ -260,19 +260,19 @@ html_mark_path_error (HtmlConfig *config, const gchar *nodepath)
void
html_mark_node_error (HtmlConfig *config, xmlNodePtr node)
{
- xmlSetProp(node, "class", (xmlChar*)"error");
+ xmlSetProp(node, BAD_CAST "class", BAD_CAST "error");
}
void
html_mark_node_warning (HtmlConfig *config, xmlNodePtr node)
{
- xmlSetProp(node, "class", (xmlChar*)"warning");
+ xmlSetProp(node, BAD_CAST "class", BAD_CAST "warning");
}
void
html_mark_node_notice (HtmlConfig *config, xmlNodePtr node)
{
- xmlSetProp(node, "class", (xmlChar*)"notice");
+ xmlSetProp(node, BAD_CAST "class", BAD_CAST "notice");
}
xmlNodePtr
@@ -283,7 +283,7 @@ html_render_attribute_str (xmlNodePtr parent, const gchar *node_type,
gchar *tmp;
tmp = g_strdup_printf ("%s = %s", att_name, att_val);
- node = xmlNewChild (parent, NULL, node_type, tmp);
+ node = xmlNewChild (parent, NULL, BAD_CAST node_type, BAD_CAST tmp);
g_free (tmp);
return node;
@@ -297,7 +297,7 @@ html_render_attribute_bool (xmlNodePtr parent, const gchar *node_type,
gchar *tmp;
tmp = g_strdup_printf ("%s = %s", att_name, att_val ? _("Yes") : _("No"));
- node = xmlNewChild (parent, NULL, node_type, tmp);
+ node = xmlNewChild (parent, NULL, BAD_CAST node_type, BAD_CAST tmp);
g_free (tmp);
return node;
@@ -311,13 +311,13 @@ html_render_data_model (xmlNodePtr parent, GdaDataModel *model)
g_return_val_if_fail (GDA_IS_DATA_MODEL (model), NULL);
- node = xmlNewChild (parent, NULL, "table", "");
+ node = xmlNewChild (parent, NULL, BAD_CAST "table", BAD_CAST "");
cols = gda_data_model_get_n_columns (model);
rows = gda_data_model_get_n_rows (model);
/* set the table structure */
- tr = xmlNewChild (node, NULL, "tr", NULL);
+ tr = xmlNewChild (node, NULL, BAD_CAST "tr", NULL);
for (i = 0; i < cols; i++) {
GdaColumn *column;
@@ -327,7 +327,7 @@ html_render_data_model (xmlNodePtr parent, GdaDataModel *model)
return NULL;
}
- td = xmlNewChild (tr, NULL, "th", gda_column_get_name (column));
+ td = xmlNewChild (tr, NULL, BAD_CAST "th", BAD_CAST gda_column_get_name (column));
}
/* add the model data to the XML output */
@@ -335,22 +335,22 @@ html_render_data_model (xmlNodePtr parent, GdaDataModel *model)
gint r, c;
for (r = 0; r < rows; r++) {
- tr = xmlNewChild (node, NULL, "tr", "");
+ tr = xmlNewChild (node, NULL, BAD_CAST "tr", BAD_CAST "");
for (c = 0 ; c < cols; c++) {
GValue *value;
value = (GValue *) gda_data_model_get_value_at (model, c, r, NULL);
if (!value) {
xmlNodePtr p;
- td = xmlNewChild (tr, NULL, "td", NULL);
- p = xmlNewChild (td, NULL, "p", "ERROR");
- xmlSetProp(p, "class", (xmlChar*)"null");
+ td = xmlNewChild (tr, NULL, BAD_CAST "td", NULL);
+ p = xmlNewChild (td, NULL, BAD_CAST "p", BAD_CAST "ERROR");
+ xmlSetProp(p, BAD_CAST "class", BAD_CAST "null");
}
else if (gda_value_is_null (value)) {
xmlNodePtr p;
- td = xmlNewChild (tr, NULL, "td", NULL);
- p = xmlNewChild (td, NULL, "p", "NULL");
- xmlSetProp(p, "class", (xmlChar*)"null");
+ td = xmlNewChild (tr, NULL, BAD_CAST "td", NULL);
+ p = xmlNewChild (td, NULL, BAD_CAST "p", BAD_CAST "NULL");
+ xmlSetProp(p, BAD_CAST "class", BAD_CAST "null");
}
else {
gchar *str;
@@ -358,7 +358,7 @@ html_render_data_model (xmlNodePtr parent, GdaDataModel *model)
str = g_strdup (g_value_get_boolean (value) ? "TRUE" : "FALSE");
else
str = gda_value_stringify (value);
- td = xmlNewChild (tr, NULL, "td", str);
+ td = xmlNewChild (tr, NULL, BAD_CAST "td", BAD_CAST str);
g_free (str);
}
}
diff --git a/tools/browser/canvas/browser-canvas-fkey.c b/tools/browser/canvas/browser-canvas-fkey.c
index 7642ef7..aaaf4ad 100644
--- a/tools/browser/canvas/browser-canvas-fkey.c
+++ b/tools/browser/canvas/browser-canvas-fkey.c
@@ -132,13 +132,6 @@ browser_canvas_fkey_init (BrowserCanvasFkey *cc)
cc->priv->shapes = NULL;
}
-static gboolean
-idle_remove_item (BrowserCanvasFkey *cc)
-{
- goo_canvas_item_remove (GOO_CANVAS_ITEM (cc));
- return FALSE;
-}
-
static void
fk_table_item_weak_ref_lost (BrowserCanvasFkey *cc, BrowserCanvasTable *old_table_item)
{
@@ -384,8 +377,6 @@ update_items (BrowserCanvasFkey *cc)
cc->priv->shapes = browser_canvas_canvas_shapes_remove_obsolete_shapes (cc->priv->shapes);
}
-static void popup_delete_cb (GtkMenuItem *mitem, BrowserCanvasFkey *cc);
-
/*
* item is for a single FK constraint
*/
@@ -467,13 +458,6 @@ single_item_button_press_event_cb (GooCanvasItem *ci, GooCanvasItem *target_item
*/
}
-
-static void
-popup_delete_cb (GtkMenuItem *mitem, BrowserCanvasFkey *cc)
-{
- TO_IMPLEMENT;
-}
-
static void
table_item_moved_cb (GooCanvasItem *table, BrowserCanvasFkey *cc)
{
diff --git a/tools/browser/canvas/browser-canvas-utility.c b/tools/browser/canvas/browser-canvas-utility.c
index 4435b3c..bead0fa 100644
--- a/tools/browser/canvas/browser-canvas-utility.c
+++ b/tools/browser/canvas/browser-canvas-utility.c
@@ -21,8 +21,6 @@
#include <math.h>
#include <string.h>
-static gchar *points_to_path (GooCanvasPoints *points);
-
static gboolean compute_intersect_rect_line (gdouble rectx1, gdouble recty1, gdouble rectx2, gdouble recty2,
gdouble P1x, gdouble P1y, gdouble P2x, gdouble P2y,
gdouble *R1x, gdouble *R1y, gdouble *R2x, gdouble *R2y);
@@ -726,28 +724,6 @@ browser_canvas_util_compute_handle_shapes (GooCanvasItem *parent, GSList *shapes
return retval;
}
-static gchar *
-points_to_path (GooCanvasPoints *points)
-{
- GString *string;
- gchar *path;
- gint i;
-
- g_return_val_if_fail (points, NULL);
- g_return_val_if_fail (points->num_points >= 2, NULL);
-
- string = g_string_new ("");
- g_string_append_printf (string, "M%d %d", (int) points->coords[0], (int) points->coords[1]);
-
- for (i = 1; i < points->num_points; i++)
- g_string_append_printf (string, " L%d %d",
- (int) points->coords[2*i], (int) points->coords[2*i+1]);
-
- path = string->str;
- g_string_free (string, FALSE);
- return path;
-}
-
static GSList *
browser_canvas_canvas_shape_add_to_list (GSList *list, gchar *swallow_id, GooCanvasItem *item)
{
diff --git a/tools/browser/common/gdaui-data-import.c b/tools/browser/common/gdaui-data-import.c
index ac27544..f96d3fa 100644
--- a/tools/browser/common/gdaui-data-import.c
+++ b/tools/browser/common/gdaui-data-import.c
@@ -294,6 +294,7 @@ gdaui_data_import_init (GdauiDataImport * import)
/**
* gdaui_data_import_new
+ *
* Creates a new #GdauiDataImport widget. After import, a #GdaDataModel will be created.
*
* Returns: the new widget
diff --git a/tools/browser/data-manager/data-console.c b/tools/browser/data-manager/data-console.c
index 84244fa..a935668 100644
--- a/tools/browser/data-manager/data-console.c
+++ b/tools/browser/data-manager/data-console.c
@@ -94,12 +94,6 @@ static GtkActionGroup *data_console_page_get_actions_group (BrowserPage *pa
static const gchar *data_console_page_get_actions_ui (BrowserPage *page);
static GtkWidget *data_console_page_get_tab_label (BrowserPage *page, GtkWidget **out_close_button);
-enum {
- DUMMY,
- LAST_SIGNAL
-};
-
-static guint data_console_signals[LAST_SIGNAL] = { };
static GObjectClass *parent_class = NULL;
/*
diff --git a/tools/browser/data-manager/data-favorite-selector.c b/tools/browser/data-manager/data-favorite-selector.c
index 9350911..9ada444 100644
--- a/tools/browser/data-manager/data-favorite-selector.c
+++ b/tools/browser/data-manager/data-favorite-selector.c
@@ -445,9 +445,7 @@ static gboolean tree_store_drag_can_drag_cb (GdauiTreeStore *store, const gchar
DataFavoriteSelector *tsel);
static gboolean tree_store_drag_get_cb (GdauiTreeStore *store, const gchar *path,
GtkSelectionData *selection_data, DataFavoriteSelector *tsel);
-static void trash_data_received_cb (GtkWidget *widget, GdkDragContext *context, gint x, gint y,
- GtkSelectionData *selection_data, guint target_type, guint time,
- DataFavoriteSelector *tsel);
+
/**
* data_favorite_selector_new
*
diff --git a/tools/browser/query-exec/query-console.c b/tools/browser/query-exec/query-console.c
index 9d4f93c..d08eb0d 100644
--- a/tools/browser/query-exec/query-console.c
+++ b/tools/browser/query-exec/query-console.c
@@ -136,12 +136,6 @@ static GtkActionGroup *query_console_page_get_actions_group (BrowserPage *p
static const gchar *query_console_page_get_actions_ui (BrowserPage *page);
static GtkWidget *query_console_page_get_tab_label (BrowserPage *page, GtkWidget **out_close_button);
-enum {
- DUMMY,
- LAST_SIGNAL
-};
-
-static guint query_console_signals[LAST_SIGNAL] = { };
static GObjectClass *parent_class = NULL;
/*
@@ -1000,8 +994,8 @@ query_exec_fetch_cb (QueryConsole *tconsole)
/**
* query_console_set_text
- * @console:
- * @text:
+ * @console: a #QueryConsole
+ * @text: the new text
*
* Replaces the edited SQL with @text in @console
*/
diff --git a/tools/browser/query-exec/query-favorite-selector.c b/tools/browser/query-exec/query-favorite-selector.c
index 5cc53a7..f43b71c 100644
--- a/tools/browser/query-exec/query-favorite-selector.c
+++ b/tools/browser/query-exec/query-favorite-selector.c
@@ -410,9 +410,6 @@ static gboolean tree_store_drag_can_drag_cb (GdauiTreeStore *store, const gchar
QueryFavoriteSelector *tsel);
static gboolean tree_store_drag_get_cb (GdauiTreeStore *store, const gchar *path,
GtkSelectionData *selection_data, QueryFavoriteSelector *tsel);
-static void trash_data_received_cb (GtkWidget *widget, GdkDragContext *context, gint x, gint y,
- GtkSelectionData *selection_data, guint target_type, guint time,
- QueryFavoriteSelector *tsel);
/**
* query_favorite_selector_new
*
diff --git a/tools/browser/schema-browser/favorite-selector.c b/tools/browser/schema-browser/favorite-selector.c
index a9a4a85..cf18ce3 100644
--- a/tools/browser/schema-browser/favorite-selector.c
+++ b/tools/browser/schema-browser/favorite-selector.c
@@ -208,9 +208,7 @@ static gboolean tree_store_drag_can_drag_cb (GdauiTreeStore *store, const gchar
FavoriteSelector *tsel);
static gboolean tree_store_drag_get_cb (GdauiTreeStore *store, const gchar *path,
GtkSelectionData *selection_data, FavoriteSelector *tsel);
-static void trash_data_received_cb (GtkWidget *widget, GdkDragContext *context, gint x, gint y,
- GtkSelectionData *selection_data, guint target_type, guint time,
- FavoriteSelector *tsel);
+
/**
* favorite_selector_new
*
diff --git a/tools/browser/schema-browser/relations-diagram.c b/tools/browser/schema-browser/relations-diagram.c
index 842b0d6..f67520e 100644
--- a/tools/browser/schema-browser/relations-diagram.c
+++ b/tools/browser/schema-browser/relations-diagram.c
@@ -73,12 +73,6 @@ enum {
PROP_0,
};
-enum {
- SELECTION_CHANGED,
- LAST_SIGNAL
-};
-
-static guint relations_diagram_signals[LAST_SIGNAL] = { 0 };
static GObjectClass *parent_class = NULL;
diff --git a/tools/browser/schema-browser/table-columns.c b/tools/browser/schema-browser/table-columns.c
index 3549cb4..f58dfb9 100644
--- a/tools/browser/schema-browser/table-columns.c
+++ b/tools/browser/schema-browser/table-columns.c
@@ -49,12 +49,6 @@ static void table_columns_dispose (GObject *object);
static void meta_changed_cb (BrowserConnection *bcnc, GdaMetaStruct *mstruct, TableColumns *tcolumns);
-enum {
- SELECTION_CHANGED,
- LAST_SIGNAL
-};
-
-static guint table_columns_signals[LAST_SIGNAL] = { 0 };
static GObjectClass *parent_class = NULL;
diff --git a/tools/browser/schema-browser/table-info.c b/tools/browser/schema-browser/table-info.c
index 1a9416f..f8c54fa 100644
--- a/tools/browser/schema-browser/table-info.c
+++ b/tools/browser/schema-browser/table-info.c
@@ -82,12 +82,6 @@ enum {
PROP_0,
};
-enum {
- SELECTION_CHANGED,
- LAST_SIGNAL
-};
-
-static guint table_info_signals[LAST_SIGNAL] = { 0 };
static GObjectClass *parent_class = NULL;
diff --git a/tools/browser/schema-browser/table-preferences.c b/tools/browser/schema-browser/table-preferences.c
index 1c4c469..6dcdca5 100644
--- a/tools/browser/schema-browser/table-preferences.c
+++ b/tools/browser/schema-browser/table-preferences.c
@@ -67,12 +67,6 @@ static void update_column_properties (TablePreferences *tpref);
static void meta_changed_cb (BrowserConnection *bcnc, GdaMetaStruct *mstruct, TablePreferences *tpreferences);
static void plugins_combo_changed_cb (GtkComboBox *combo, TablePreferences *tpref);
-enum {
- DUMMY,
- LAST_SIGNAL
-};
-
-static guint table_preferences_signals[LAST_SIGNAL] = { };
static GObjectClass *parent_class = NULL;
#ifdef G_OS_WIN32
diff --git a/tools/browser/schema-browser/table-relations.c b/tools/browser/schema-browser/table-relations.c
index bef1eab..0a148ff 100644
--- a/tools/browser/schema-browser/table-relations.c
+++ b/tools/browser/schema-browser/table-relations.c
@@ -46,12 +46,6 @@ static void table_relations_dispose (GObject *object);
static void meta_changed_cb (BrowserConnection *bcnc, GdaMetaStruct *mstruct, TableRelations *trels);
-enum {
- SELECTION_CHANGED,
- LAST_SIGNAL
-};
-
-static guint table_relations_signals[LAST_SIGNAL] = { 0 };
static GObjectClass *parent_class = NULL;
diff --git a/tools/browser/support.c b/tools/browser/support.c
index 5d8c60e..3cdc874 100644
--- a/tools/browser/support.c
+++ b/tools/browser/support.c
@@ -33,6 +33,9 @@ GtkOSXApplication *theApp = NULL;
#endif
/**
+ * browser_connection_open
+ * @error: a place to store errors, or %NULL
+ *
* Display a login dialog and, if validated, create a new #BrowserConnection
*
* Returns: a new #BrowserConnection, or %NULL (the caller DOES NOT OWN a reference to the returned value)
@@ -59,6 +62,10 @@ browser_connection_open (GError **error)
}
/**
+ * browser_connection_close
+ * @parent: a #GtkWindow
+ * @bcnc: a #BrowserConnection object
+ *
* Displays a warning dialog and close @bcnc
*
* Returns: %TRUE if the connection has been closed
diff --git a/tools/command-exec.c b/tools/command-exec.c
index a7ab79f..5b0cfa4 100644
--- a/tools/command-exec.c
+++ b/tools/command-exec.c
@@ -350,7 +350,7 @@ gda_internal_command_dict_sync (SqlConsole *console, GdaConnection *cnc, const g
GdaMetaContext context;
memset (&context, 0, sizeof (context));
if (*args[0] == '_')
- context.table_name = args[0];
+ context.table_name = (gchar*) args[0];
else
context.table_name = g_strdup_printf ("_%s", args[0]);
if (!gda_connection_update_meta_store (cnc, &context, error)) {
diff --git a/tools/gda-sql.c b/tools/gda-sql.c
index 34cfba8..9155293 100644
--- a/tools/gda-sql.c
+++ b/tools/gda-sql.c
@@ -1974,9 +1974,11 @@ static GdaInternalCommandResult *extra_command_httpd (SqlConsole *console, GdaCo
GError **error, gpointer data);
#endif
+#ifdef NONE
static GdaInternalCommandResult *extra_command_lo_update (SqlConsole *console, GdaConnection *cnc,
const gchar **args,
GError **error, gpointer data);
+#endif
static GdaInternalCommandResult *extra_command_export (SqlConsole *console, GdaConnection *cnc,
const gchar **args,
GError **error, gpointer data);
@@ -2412,7 +2414,7 @@ build_internal_commands_list (void)
c->arguments_delimiter_func = NULL;
c->unquote_args = TRUE;
commands->commands = g_slist_prepend (commands->commands, c);
- */
+ */
c = g_new0 (GdaInternalCommand, 1);
c->group = _("Query buffer");
diff --git a/tools/web-server.c b/tools/web-server.c
index fa1a2be..38d8d05 100644
--- a/tools/web-server.c
+++ b/tools/web-server.c
@@ -100,7 +100,6 @@ typedef struct {
} TmpResource;
static TmpResource *tmp_resource_add (WebServer *server, const gchar *path, gchar *data, gsize data_length);
-static TmpResource *tmp_static_data_add (WebServer *server, const gchar *path, gchar *data, gsize data_length);
static gboolean delete_tmp_resource (WebServer *server);
static void tmp_resource_free (TmpResource *data);
@@ -2079,24 +2078,6 @@ tmp_resource_add (WebServer *server, const gchar *path, gchar *data, gsize data_
return td;
}
-/*
- * @data is static
- */
-static TmpResource *
-tmp_static_data_add (WebServer *server, const gchar *path, gchar *data, gsize data_length)
-{
- TmpResource *td;
-
- td = g_new0 (TmpResource, 1);
- td->path = g_strdup (path);
- td->data = data;
- td->size = data_length;
- td->expiration_date = 0;
- g_hash_table_insert (server->priv->resources_hash, g_strdup (path), td);
- server->priv->resources_list = g_slist_prepend (server->priv->resources_list, td);
- return td;
-}
-
static gboolean
delete_tmp_resource (WebServer *server)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]