[empathy] Fix a logic error when expanding groups in EmpathyIndividualView



commit 054086355fe0cb29c40c08da0e9b1f106ff5407a
Author: Philip Withnall <philip withnall collabora co uk>
Date:   Mon Aug 30 10:58:40 2010 +0100

    Fix a logic error when expanding groups in EmpathyIndividualView
    
    This prevents use of uninitialised memory in the second part of the
    expression, and should cause groups to be added to the table of groups to
    expand/contract more frequently (correctly). Helps: bgo#628106

 libempathy-gtk/empathy-individual-view.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libempathy-gtk/empathy-individual-view.c b/libempathy-gtk/empathy-individual-view.c
index cffb5c9..1c8dd21 100644
--- a/libempathy-gtk/empathy-individual-view.c
+++ b/libempathy-gtk/empathy-individual-view.c
@@ -1512,7 +1512,7 @@ individual_view_row_has_child_toggled_cb (GtkTreeModel *model,
    * a hash table, and expand or contract them as appropriate all at once in
    * an idle handler which iterates over all the group rows. */
   if (g_hash_table_lookup_extended (priv->expand_groups, name, NULL,
-      &will_expand) == FALSE &&
+      &will_expand) == FALSE ||
       GPOINTER_TO_INT (will_expand) != should_expand)
     {
       g_hash_table_insert (priv->expand_groups, g_strdup (name),



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]