[ease] [player] Fix "Reveal" transition.



commit 2343b3c806e49182bc92a96ebbf78cc171696636
Author: Nate Stedman <natesm gmail com>
Date:   Sun Aug 8 07:53:45 2010 -0400

    [player] Fix "Reveal" transition.
    
    "Up" and "Down" variants didn't work, unneeded
    property changes removed.

 ease/ease-slide-actor.vala |   23 +++++++----------------
 1 files changed, 7 insertions(+), 16 deletions(-)
---
diff --git a/ease/ease-slide-actor.vala b/ease/ease-slide-actor.vala
index d3b5063..8d4013c 100644
--- a/ease/ease-slide-actor.vala
+++ b/ease/ease-slide-actor.vala
@@ -821,30 +821,21 @@ internal class Ease.SlideActor : Clutter.Group
 	private void reveal_transition(SlideActor new_slide,
 	                               Clutter.Group container, uint length)
 	{
-		// TODO: make this transition not a total hack
-		((Clutter.Container)get_parent()).raise_child(this, new_slide);
+		(get_parent() as Clutter.Container).raise_child(this, new_slide);
 
 		switch (slide.variant)
 		{
-			case TransitionVariant.TOP:
-				new_slide.y = slide.height;
-				animate(EASE_SLIDE, length, "y", -new_slide.y);
-				new_slide.y = 0;
+			case TransitionVariant.UP:
+				animate(EASE_SLIDE, length, "y", -(float)slide.height);
 				break;
-			case TransitionVariant.BOTTOM:
-				new_slide.y = -slide.height;
-				animate(EASE_SLIDE, length, "y", -new_slide.y);
-				new_slide.y = 0;
+			case TransitionVariant.DOWN:
+				animate(EASE_SLIDE, length, "y", (float)slide.height);
 				break;
 			case TransitionVariant.LEFT:
-				new_slide.x = slide.width;
-				this.animate(EASE_SLIDE, length, "x", -new_slide.x);
-				new_slide.x = 0;
+				animate(EASE_SLIDE, length, "x", -(float)slide.width);
 				break;
 			case TransitionVariant.RIGHT:
-				new_slide.x = -slide.width;
-				animate(EASE_SLIDE, length, "x", -new_slide.x);
-				new_slide.x = 0;
+				animate(EASE_SLIDE, length, "x", (float)slide.width);
 				break;
 		}
 	}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]